Source/core/html/HTMLMediaElement.h - Issue 298093004: Eliminate MediaPlayer & MediaPlayerClient abstractions(play/pause, other APIs)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLMediaElement.h

Issue 298093004: Eliminate MediaPlayer & MediaPlayerClient abstractions(play/pause, other APIs) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: fixed review comments Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/HTMLMediaElement.h

diff --git a/Source/core/html/HTMLMediaElement.h b/Source/core/html/HTMLMediaElement.h

index 3561923f765376bdb21bb63c0be635c4f16354d4..f348661c36f8d6c95a168ed3b1879ec4fa59ec4a 100644

--- a/Source/core/html/HTMLMediaElement.h

+++ b/Source/core/html/HTMLMediaElement.h

@@ -234,7 +234,7 @@ public:

// of one of them here.

virtual ExecutionContext* executionContext() const OVERRIDE FINAL { return HTMLElement::executionContext(); }

- bool hasSingleSecurityOrigin() const { return !m_player || m_player->hasSingleSecurityOrigin(); }

+ bool hasSingleSecurityOrigin() const { return webMediaPlayer() && webMediaPlayer()->hasSingleSecurityOrigin(); }

bool isFullscreen() const;

void enterFullscreen();

« no previous file with comments | « no previous file | Source/core/html/HTMLMediaElement.cpp » ('j') | no next file with comments »