Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 298093003: Make it possible to build gralloc_drm. (Closed)

Created:
6 years, 7 months ago by fjhenigman
Modified:
6 years, 6 months ago
Reviewers:
rjkroege
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add enums and defines used by gralloc_drm. These are referenced in the gralloc_drm source from android-x86. BUG=358029 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275852

Patch Set 1 #

Total comments: 2

Patch Set 2 : enums for gralloc_drm #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -0 lines) Patch
A third_party/hwcplus/include/vendor/gralloc_drm.h View 1 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
fjhenigman
Need this for our gralloc chromeos pkg.
6 years, 7 months ago (2014-05-26 19:43:16 UTC) #1
rjkroege
https://codereview.chromium.org/298093003/diff/1/third_party/hwcplus/include/hardware/gralloc.h File third_party/hwcplus/include/hardware/gralloc.h (right): https://codereview.chromium.org/298093003/diff/1/third_party/hwcplus/include/hardware/gralloc.h#newcode133 third_party/hwcplus/include/hardware/gralloc.h:133: enum { Does this belong here? The implication is ...
6 years, 7 months ago (2014-05-26 20:49:59 UTC) #2
fjhenigman
https://codereview.chromium.org/298093003/diff/1/third_party/hwcplus/include/hardware/gralloc.h File third_party/hwcplus/include/hardware/gralloc.h (right): https://codereview.chromium.org/298093003/diff/1/third_party/hwcplus/include/hardware/gralloc.h#newcode133 third_party/hwcplus/include/hardware/gralloc.h:133: enum { On 2014/05/26 20:49:59, rjkroege wrote: > Does ...
6 years, 6 months ago (2014-06-01 20:56:52 UTC) #3
fjhenigman
On 2014/06/01 20:56:52, fjhenigman wrote: > https://codereview.chromium.org/298093003/diff/1/third_party/hwcplus/include/hardware/gralloc.h > File third_party/hwcplus/include/hardware/gralloc.h (right): > > https://codereview.chromium.org/298093003/diff/1/third_party/hwcplus/include/hardware/gralloc.h#newcode133 > ...
6 years, 6 months ago (2014-06-08 19:56:32 UTC) #4
rjkroege
lgtm
6 years, 6 months ago (2014-06-09 14:08:19 UTC) #5
fjhenigman
The CQ bit was checked by fjhenigman@chromium.org
6 years, 6 months ago (2014-06-09 14:24:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fjhenigman@chromium.org/298093003/20001
6 years, 6 months ago (2014-06-09 14:25:27 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-09 20:28:45 UTC) #8
Message was sent while issue was closed.
Change committed as 275852

Powered by Google App Engine
This is Rietveld 408576698