Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 298093002: Fix define typo in Mac OS X build

Created:
6 years, 7 months ago by Nils Barth (inactive)
Modified:
6 years, 7 months ago
Reviewers:
Mark Mentovai
CC:
chromium-reviews
Visibility:
Public.

Description

Fix define typo in Mac OS X build This fixes a typo in: Mac OS X build: turn off common word macros in AssertMacros.h https://codereview.chromium.org/277273002/ I wrote (*singular*): define __ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE 0 This should have been (*plural*, with 'S' at end): define __ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORES 0 This fixes it, sorry for noise. TBR=mark

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Nils Barth (inactive)
The CQ bit was checked by nbarth@chromium.org
6 years, 7 months ago (2014-05-26 03:02:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/298093002/1
6 years, 7 months ago (2014-05-26 03:03:06 UTC) #2
Nils Barth (inactive)
Hi Mark, found a typo when de-crufting, fixed; apologies!
6 years, 7 months ago (2014-05-26 03:05:11 UTC) #3
Nils Barth (inactive)
Mac compile failures due to GTM (Google Toolbox for Mac, third_party/google_toolbox_for_mac) using the unprefixed macros. ...
6 years, 7 months ago (2014-05-26 04:15:07 UTC) #4
Nils Barth (inactive)
The CQ bit was unchecked by nbarth@chromium.org
6 years, 7 months ago (2014-05-26 04:28:36 UTC) #5
Mark Mentovai
LGTM
6 years, 7 months ago (2014-05-27 02:50:35 UTC) #6
Mark Mentovai
6 years, 7 months ago (2014-05-27 02:50:53 UTC) #7
(LGTM is conditional on rolling GTM)

Powered by Google App Engine
This is Rietveld 408576698