Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: pkg/compiler/lib/src/js_model/closure_visitors.dart

Issue 2980913002: Clean up code comments based on the changes in response to sra and johnniwinther's CL comments. (oo… (Closed)
Patch Set: Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/js_model/closure.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js_model/closure_visitors.dart
diff --git a/pkg/compiler/lib/src/js_model/closure_visitors.dart b/pkg/compiler/lib/src/js_model/closure_visitors.dart
index e3d1c97f8168959d73e04df9e75412ab82f9b0e6..f37bdea77c8a339fa9d1a39deda3e27594fa55c3 100644
--- a/pkg/compiler/lib/src/js_model/closure_visitors.dart
+++ b/pkg/compiler/lib/src/js_model/closure_visitors.dart
@@ -13,19 +13,13 @@ import 'closure.dart';
/// various points to build ClosureScope that can respond to queries
/// about how a particular variable is being used at any point in the code.
class ClosureScopeBuilder extends ir.Visitor {
- /// A map of each visited call node with the associated information about what
- /// variables are captured/used. Each ir.Node key corresponds to a scope that
- /// was encountered while visiting a closure (initially called through
- /// [translateLazyIntializer] or [translateConstructorOrProcedure]).
- // TODODODOOOOOO
+ /// A map of each for loop statement and the corresponding variable
+ /// information about what variables are captured/used in the this for loop
+ /// declaration.
final Map<ir.Statement, LoopClosureScope> _loopClosureScopeMap;
/// Map entities to their corresponding scope information (such as what
- /// variables are captured/used). The distinction between this map and
- /// [_closureInfoMap] is that [_closureInfoMap] stores this data for closures
- /// specifically, whereas [_scopeInfoMap] stores this information for entities
- /// that are *not* closures (this information is used by the locals handler).
- /// The union of these two maps represents all the scopes encountered.
+ /// variables are captured/used).
final Map<Entity, ScopeInfo> _scopeInfoMap;
/// A map of the nodes that we have flagged as necessary to generate closure
« no previous file with comments | « pkg/compiler/lib/src/js_model/closure.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698