Issue 2980913002: Clean up code comments based on the changes in response to sra and johnniwinther's CL comments. (oo…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2980913002: Clean up code comments based on the changes in response to sra and johnniwinther's CL comments. (oo… (Closed)

Created:
3 years, 5 months ago by Emily Fortuna

Modified:
3 years, 5 months ago

Reviewers:
sra1

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Clean up code comments based on the changes in response to sra and johnniwinther's CL comments. (oops) BUG= Committed: https://github.com/dart-lang/sdk/commit/b5ded27c32bb5fc820b0cbea6a52ee5fc2143dbd

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -13 lines)			Patch
	M	pkg/compiler/lib/src/js_model/closure.dart	View		1 chunk	+0 lines, -3 lines	0 comments	Download
	M	pkg/compiler/lib/src/js_model/closure_visitors.dart	View		1 chunk	+4 lines, -10 lines	0 comments	Download

Total messages: 5 (2 generated)

Emily Fortuna

I made the change in the code and tested it, but neglected to update the ...

3 years, 5 months ago (2017-07-13 21:11:33 UTC) #2

Emily Fortuna

Committed patchset #1 (id:1) manually as b5ded27c32bb5fc820b0cbea6a52ee5fc2143dbd (presubmit successful).

3 years, 5 months ago (2017-07-13 21:11:48 UTC) #4

Message was sent while issue was closed.

lgtm