Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(965)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2980883003: Remove code associated with the old "kompile" functionality. (Closed)

Created:
3 years, 5 months ago by Paul Berry
Modified:
3 years, 5 months ago
Reviewers:
ahe, scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove code associated with the old "kompile" functionality. This code is no longer needed because we no longer run the front end in "kompile" mode. Also remove the old expectations files used by the "kompile" tests. I will remove more code in future CLs. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/04ad043f49adf2e954a9eafc10d2f216c77debf3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -3325 lines) Patch
M pkg/analyzer/lib/src/dart/analysis/file_state.dart View 3 chunks +0 lines, -25 lines 0 comments Download
D pkg/analyzer/lib/src/fasta/analyzer.dart View 1 chunk +0 lines, -37 lines 0 comments Download
M pkg/analyzer/lib/src/fasta/analyzer_diet_listener.dart View 4 chunks +32 lines, -65 lines 0 comments Download
M pkg/analyzer/lib/src/fasta/analyzer_loader.dart View 2 chunks +3 lines, -31 lines 0 comments Download
M pkg/analyzer/lib/src/fasta/analyzer_target.dart View 1 chunk +3 lines, -26 lines 0 comments Download
M pkg/analyzer/lib/src/fasta/ast_builder.dart View 8 chunks +7 lines, -53 lines 0 comments Download
D pkg/analyzer/lib/src/fasta/element_store.dart View 1 chunk +0 lines, -326 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/parser_fasta.dart View 2 chunks +2 lines, -7 lines 0 comments Download
M pkg/analyzer/test/generated/parser_fasta_test.dart View 4 chunks +1 line, -44 lines 0 comments Download
M pkg/front_end/test/fasta/ast_builder_test.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/front_end/test/fasta/testing/suite.dart View 7 chunks +6 lines, -29 lines 0 comments Download
M pkg/front_end/testcases/ast_builder.status View 11 chunks +17 lines, -22 lines 0 comments Download
D pkg/front_end/testcases/await.dart.dartk.expect View 1 chunk +0 lines, -7 lines 0 comments Download
D pkg/front_end/testcases/cascade.dart.dartk.expect View 1 chunk +0 lines, -14 lines 0 comments Download
D pkg/front_end/testcases/casts.dart.dartk.expect View 1 chunk +0 lines, -18 lines 0 comments Download
D pkg/front_end/testcases/cycles.dart.dartk.expect View 1 chunk +0 lines, -11 lines 0 comments Download
D pkg/front_end/testcases/expressions.dart.dartk.expect View 1 chunk +0 lines, -37 lines 0 comments Download
D pkg/front_end/testcases/fibonacci.dart.dartk.expect View 1 chunk +0 lines, -14 lines 0 comments Download
D pkg/front_end/testcases/hello.dart.dartk.expect View 1 chunk +0 lines, -7 lines 0 comments Download
D pkg/front_end/testcases/inference/assign_local.dart.dartk.expect View 1 chunk +0 lines, -19 lines 0 comments Download
D pkg/front_end/testcases/inference/coerce_bottom_and_null_types.dart.dartk.expect View 1 chunk +0 lines, -21 lines 0 comments Download
D pkg/front_end/testcases/inference/constructors_downwards_with_constraint.dart.dartk.expect View 1 chunk +0 lines, -22 lines 0 comments Download
D pkg/front_end/testcases/inference/constructors_too_many_positional_arguments.dart.dartk.expect View 1 chunk +0 lines, -12 lines 0 comments Download
D pkg/front_end/testcases/inference/dont_infer_type_when_initializer_is_null.dart.dartk.expect View 1 chunk +0 lines, -11 lines 0 comments Download
D pkg/front_end/testcases/inference/downwards_inference_assignment_statements.dart.dartk.expect View 1 chunk +0 lines, -9 lines 0 comments Download
D pkg/front_end/testcases/inference/downwards_inference_for_each.dart.dartk.expect View 1 chunk +0 lines, -15 lines 0 comments Download
D pkg/front_end/testcases/inference/downwards_inference_yield_yield_star.dart.dartk.expect View 1 chunk +0 lines, -21 lines 0 comments Download
D pkg/front_end/testcases/inference/for_loop_empty_condition.dart.dartk.expect View 1 chunk +0 lines, -15 lines 0 comments Download
D pkg/front_end/testcases/inference/for_loop_initializer_expression.dart.dartk.expect View 1 chunk +0 lines, -16 lines 0 comments Download
D pkg/front_end/testcases/inference/for_loop_promotion.dart.dartk.expect View 1 chunk +0 lines, -12 lines 0 comments Download
D pkg/front_end/testcases/inference/future_union_downwards_generic_method_with_future_return.dart.dartk.expect View 1 chunk +0 lines, -15 lines 0 comments Download
D pkg/front_end/testcases/inference/future_union_upwards_generic_methods.dart.dartk.expect View 1 chunk +0 lines, -28 lines 0 comments Download
D pkg/front_end/testcases/inference/generic_methods_infer_js_builtin.dart.dartk.expect View 1 chunk +0 lines, -5 lines 0 comments Download
D pkg/front_end/testcases/inference/infer_type_on_var.dart.dartk.expect View 1 chunk +0 lines, -11 lines 0 comments Download
D pkg/front_end/testcases/inference/infer_type_on_var2.dart.dartk.expect View 1 chunk +0 lines, -10 lines 0 comments Download
D pkg/front_end/testcases/inference/infer_type_regardless_of_declaration_order_or_cycles.dart.dartk.expect View 1 chunk +0 lines, -26 lines 0 comments Download
D pkg/front_end/testcases/inference/infer_type_regardless_of_declaration_order_or_cycles_b.dart.dartk.expect View 1 chunk +0 lines, -10 lines 0 comments Download
D pkg/front_end/testcases/inference/infer_types_on_loop_indices_for_loop_with_inference.dart.dartk.expect View 1 chunk +0 lines, -9 lines 0 comments Download
D pkg/front_end/testcases/inference/infer_use_of_void_local.dart.dartk.expect View 1 chunk +0 lines, -8 lines 0 comments Download
D pkg/front_end/testcases/inference/inferred_type_block_closure_no_args_no_return.dart.dartk.expect View 1 chunk +0 lines, -6 lines 0 comments Download
D pkg/front_end/testcases/inference/instantiate_to_bounds_invoke_constructor_no_bound.dart.dartk.expect View 1 chunk +0 lines, -12 lines 0 comments Download
D pkg/front_end/testcases/inference/int_upwards_local.dart.dartk.expect View 1 chunk +0 lines, -6 lines 0 comments Download
D pkg/front_end/testcases/inference/list_literals.dart.dartk.expect View 1 chunk +0 lines, -21 lines 0 comments Download
D pkg/front_end/testcases/inference/list_literals_can_infer_null_bottom.dart.dartk.expect View 1 chunk +0 lines, -10 lines 0 comments Download
D pkg/front_end/testcases/inference/local_reference_upwards_local.dart.dartk.expect View 1 chunk +0 lines, -8 lines 0 comments Download
D pkg/front_end/testcases/inference/map_literals.dart.dartk.expect View 1 chunk +0 lines, -22 lines 0 comments Download
D pkg/front_end/testcases/inference/map_literals_can_infer_null.dart.dartk.expect View 1 chunk +0 lines, -7 lines 0 comments Download
D pkg/front_end/testcases/inference/no_error_when_declared_type_is_num_and_assigned_null.dart.dartk.expect View 1 chunk +0 lines, -11 lines 0 comments Download
D pkg/front_end/testcases/inference/null_coalescing_operator.dart.dartk.expect View 1 chunk +0 lines, -9 lines 0 comments Download
D pkg/front_end/testcases/inference/null_coalescing_operator_2.dart.dartk.expect View 1 chunk +0 lines, -8 lines 0 comments Download
D pkg/front_end/testcases/inference/overloaded_int_operators.dart.dartk.expect View 1 chunk +0 lines, -45 lines 0 comments Download
D pkg/front_end/testcases/inference/propagate_variable_get.dart.dartk.expect View 1 chunk +0 lines, -7 lines 0 comments Download
D pkg/front_end/testcases/inference/super_method_invocation.dart.dartk.expect View 1 chunk +0 lines, -20 lines 0 comments Download
D pkg/front_end/testcases/inference/symbol_literal.dart.dartk.expect View 1 chunk +0 lines, -7 lines 0 comments Download
D pkg/front_end/testcases/inference/type_promotion_simple.dart.dartk.expect View 1 chunk +0 lines, -10 lines 0 comments Download
D pkg/front_end/testcases/inference/type_promotion_stopped_by_access_in_a_closure.dart.dartk.expect View 1 chunk +0 lines, -14 lines 0 comments Download
D pkg/front_end/testcases/inference/type_promotion_stopped_by_assignment_in_scope.dart.dartk.expect View 1 chunk +0 lines, -11 lines 0 comments Download
D pkg/front_end/testcases/inference/type_promotion_stopped_by_mutation_in_a_closure.dart.dartk.expect View 1 chunk +0 lines, -13 lines 0 comments Download
D pkg/front_end/testcases/inference/unsafe_block_closure_inference_in_list_untyped.dart.dartk.expect View 1 chunk +0 lines, -8 lines 0 comments Download
D pkg/front_end/testcases/inference/unsafe_block_closure_inference_in_map_untyped.dart.dartk.expect View 1 chunk +0 lines, -8 lines 0 comments Download
D pkg/front_end/testcases/invocations.dart.dartk.expect View 1 chunk +0 lines, -12 lines 0 comments Download
D pkg/front_end/testcases/literals.dart.dartk.expect View 1 chunk +0 lines, -43 lines 0 comments Download
D pkg/front_end/testcases/platform.dart.dartk.expect View 1 chunk +0 lines, -4 lines 0 comments Download
D pkg/front_end/testcases/rasta/abstract_constructor.dart.dartk.expect View 1 chunk +0 lines, -11 lines 0 comments Download
D pkg/front_end/testcases/rasta/bad_constructor_redirection.dart.dartk.expect View 1 chunk +0 lines, -15 lines 0 comments Download
D pkg/front_end/testcases/rasta/bad_continue.dart.dartk.expect View 1 chunk +0 lines, -7 lines 0 comments Download
D pkg/front_end/testcases/rasta/bad_default_constructor.dart.dartk.expect View 1 chunk +0 lines, -17 lines 0 comments Download
D pkg/front_end/testcases/rasta/bad_explicit_super_constructor.dart.dartk.expect View 1 chunk +0 lines, -18 lines 0 comments Download
D pkg/front_end/testcases/rasta/bad_implicit_super_constructor.dart.dartk.expect View 1 chunk +0 lines, -18 lines 0 comments Download
D pkg/front_end/testcases/rasta/bad_interpolation.dart.dartk.expect View 1 chunk +0 lines, -5 lines 0 comments Download
D pkg/front_end/testcases/rasta/bad_redirection.dart.dartk.expect View 1 chunk +0 lines, -16 lines 0 comments Download
D pkg/front_end/testcases/rasta/bad_setter_initializer.dart.dartk.expect View 1 chunk +0 lines, -13 lines 0 comments Download
D pkg/front_end/testcases/rasta/bad_unicode.dart.dartk.expect View 1 chunk +0 lines, -7 lines 0 comments Download
D pkg/front_end/testcases/rasta/breaking_bad.dart.dartk.expect View 1 chunk +0 lines, -8 lines 0 comments Download
D pkg/front_end/testcases/rasta/cascades.dart.dartk.expect View 1 chunk +0 lines, -16 lines 0 comments Download
D pkg/front_end/testcases/rasta/class_hierarchy.dart.dartk.expect View 1 chunk +0 lines, -26 lines 0 comments Download
D pkg/front_end/testcases/rasta/class_member.dart.dartk.expect View 1 chunk +0 lines, -21 lines 0 comments Download
D pkg/front_end/testcases/rasta/constant_get_and_invoke.dart.dartk.expect View 1 chunk +0 lines, -8 lines 0 comments Download
D pkg/front_end/testcases/rasta/deferred_lib.dart.dartk.expect View 1 chunk +0 lines, -5 lines 0 comments Download
D pkg/front_end/testcases/rasta/deferred_load.dart.dartk.expect View 1 chunk +0 lines, -7 lines 0 comments Download
D pkg/front_end/testcases/rasta/duplicated_mixin.dart.dartk.expect View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/front_end/testcases/rasta/enum.dart.dartk.expect View 1 chunk +0 lines, -16 lines 0 comments Download
D pkg/front_end/testcases/rasta/export.dart.dartk.expect View 1 chunk +0 lines, -2 lines 0 comments Download
D pkg/front_end/testcases/rasta/external_factory_redirection.dart.dartk.expect View 1 chunk +0 lines, -9 lines 0 comments Download
D pkg/front_end/testcases/rasta/foo.dart.dartk.expect View 1 chunk +0 lines, -7 lines 0 comments Download
D pkg/front_end/testcases/rasta/for_loop.dart.dartk.expect View 1 chunk +0 lines, -13 lines 0 comments Download
D pkg/front_end/testcases/rasta/generic_factory.dart.dartk.expect View 1 chunk +0 lines, -48 lines 0 comments Download
D pkg/front_end/testcases/rasta/hello.dart.dartk.expect View 1 chunk +0 lines, -7 lines 0 comments Download
D pkg/front_end/testcases/rasta/import_export.dart.dartk.expect View 1 chunk +0 lines, -7 lines 0 comments Download
D pkg/front_end/testcases/rasta/issue_000001.dart.dartk.expect View 1 chunk +0 lines, -10 lines 0 comments Download
D pkg/front_end/testcases/rasta/issue_000002.dart.dartk.expect View 1 chunk +0 lines, -19 lines 0 comments Download
D pkg/front_end/testcases/rasta/issue_000004.dart.dartk.expect View 1 chunk +0 lines, -34 lines 0 comments Download
D pkg/front_end/testcases/rasta/issue_000006.dart.dartk.expect View 1 chunk +0 lines, -7 lines 0 comments Download
D pkg/front_end/testcases/rasta/issue_000007.dart.dartk.expect View 1 chunk +0 lines, -27 lines 0 comments Download
D pkg/front_end/testcases/rasta/issue_000008.dart.dartk.expect View 1 chunk +0 lines, -13 lines 0 comments Download
D pkg/front_end/testcases/rasta/issue_000011.dart.dartk.expect View 1 chunk +0 lines, -12 lines 0 comments Download
D pkg/front_end/testcases/rasta/issue_000012.dart.dartk.expect View 1 chunk +0 lines, -19 lines 0 comments Download
D pkg/front_end/testcases/rasta/issue_000025.dart.dartk.expect View 1 chunk +0 lines, -11 lines 0 comments Download
D pkg/front_end/testcases/rasta/issue_000026.dart.dartk.expect View 1 chunk +0 lines, -23 lines 0 comments Download
D pkg/front_end/testcases/rasta/issue_000031.dart.dartk.expect View 1 chunk +0 lines, -6 lines 0 comments Download
D pkg/front_end/testcases/rasta/issue_000032.dart.dartk.expect View 1 chunk +0 lines, -10 lines 0 comments Download
D pkg/front_end/testcases/rasta/issue_000033.dart.dartk.expect View 1 chunk +0 lines, -4 lines 0 comments Download
D pkg/front_end/testcases/rasta/issue_000034.dart.dartk.expect View 1 chunk +0 lines, -12 lines 0 comments Download
D pkg/front_end/testcases/rasta/issue_000035.dart.dartk.expect View 1 chunk +0 lines, -9 lines 0 comments Download
D pkg/front_end/testcases/rasta/issue_000035a.dart.dartk.expect View 1 chunk +0 lines, -8 lines 0 comments Download
D pkg/front_end/testcases/rasta/issue_000036.dart.dartk.expect View 1 chunk +0 lines, -5 lines 0 comments Download
D pkg/front_end/testcases/rasta/issue_000039.dart.dartk.expect View 1 chunk +0 lines, -13 lines 0 comments Download
D pkg/front_end/testcases/rasta/issue_000041.dart.dartk.expect View 1 chunk +0 lines, -16 lines 0 comments Download
D pkg/front_end/testcases/rasta/issue_000042.dart.dartk.expect View 1 chunk +0 lines, -26 lines 0 comments Download
D pkg/front_end/testcases/rasta/issue_000043.dart.dartk.expect View 1 chunk +0 lines, -11 lines 0 comments Download
D pkg/front_end/testcases/rasta/issue_000044.dart.dartk.expect View 1 chunk +0 lines, -25 lines 0 comments Download
D pkg/front_end/testcases/rasta/issue_000045.dart.dartk.expect View 1 chunk +0 lines, -5 lines 0 comments Download
D pkg/front_end/testcases/rasta/issue_000046.dart.dartk.expect View 1 chunk +0 lines, -9 lines 0 comments Download
D pkg/front_end/testcases/rasta/issue_000047.dart.dartk.expect View 1 chunk +0 lines, -5 lines 0 comments Download
D pkg/front_end/testcases/rasta/issue_000048.dart.dartk.expect View 1 chunk +0 lines, -28 lines 0 comments Download
D pkg/front_end/testcases/rasta/issue_000052.dart.dartk.expect View 1 chunk +0 lines, -10 lines 0 comments Download
D pkg/front_end/testcases/rasta/issue_000053.dart.dartk.expect View 1 chunk +0 lines, -16 lines 0 comments Download
D pkg/front_end/testcases/rasta/issue_000067.dart.dartk.expect View 1 chunk +0 lines, -32 lines 0 comments Download
D pkg/front_end/testcases/rasta/issue_000068.dart.dartk.expect View 1 chunk +0 lines, -30 lines 0 comments Download
D pkg/front_end/testcases/rasta/issue_000069.dart.dartk.expect View 1 chunk +0 lines, -10 lines 0 comments Download
D pkg/front_end/testcases/rasta/issue_000070.dart.dartk.expect View 1 chunk +0 lines, -41 lines 0 comments Download
D pkg/front_end/testcases/rasta/issue_000080.dart.dartk.expect View 1 chunk +0 lines, -31 lines 0 comments Download
D pkg/front_end/testcases/rasta/issue_000081.dart.dartk.expect View 1 chunk +0 lines, -24 lines 0 comments Download
D pkg/front_end/testcases/rasta/malformed_const_constructor.dart.dartk.expect View 1 chunk +0 lines, -12 lines 0 comments Download
D pkg/front_end/testcases/rasta/malformed_function.dart.dartk.expect View 1 chunk +0 lines, -6 lines 0 comments Download
D pkg/front_end/testcases/rasta/malformed_function_type.dart.dartk.expect View 1 chunk +0 lines, -6 lines 0 comments Download
D pkg/front_end/testcases/rasta/mandatory_parameter_initializer.dart.dartk.expect View 1 chunk +0 lines, -4 lines 0 comments Download
D pkg/front_end/testcases/rasta/mixin_library.dart.dartk.expect View 1 chunk +0 lines, -32 lines 0 comments Download
D pkg/front_end/testcases/rasta/native_is_illegal.dart.dartk.expect View 1 chunk +0 lines, -16 lines 0 comments Download
D pkg/front_end/testcases/rasta/parser_error.dart.dartk.expect View 1 chunk +0 lines, -10 lines 0 comments Download
D pkg/front_end/testcases/rasta/previsit_deferred.dart.dartk.expect View 1 chunk +0 lines, -7 lines 0 comments Download
D pkg/front_end/testcases/rasta/static.dart.dartk.expect View 1 chunk +0 lines, -80 lines 0 comments Download
D pkg/front_end/testcases/rasta/super.dart.dartk.expect View 1 chunk +0 lines, -259 lines 0 comments Download
D pkg/front_end/testcases/rasta/super_initializer.dart.dartk.expect View 1 chunk +0 lines, -27 lines 0 comments Download
D pkg/front_end/testcases/rasta/super_mixin.dart.dartk.expect View 1 chunk +0 lines, -113 lines 0 comments Download
D pkg/front_end/testcases/rasta/super_operator.dart.dartk.expect View 1 chunk +0 lines, -29 lines 0 comments Download
D pkg/front_end/testcases/rasta/supports_reflection.dart.dartk.expect View 1 chunk +0 lines, -7 lines 0 comments Download
D pkg/front_end/testcases/rasta/switch_execution_case_t02.dart.dartk.expect View 1 chunk +0 lines, -59 lines 0 comments Download
D pkg/front_end/testcases/rasta/switch_fall_through.dart.dartk.expect View 1 chunk +0 lines, -56 lines 0 comments Download
D pkg/front_end/testcases/rasta/this_invoke.dart.dartk.expect View 1 chunk +0 lines, -15 lines 0 comments Download
D pkg/front_end/testcases/rasta/try_label.dart.dartk.expect View 1 chunk +0 lines, -12 lines 0 comments Download
D pkg/front_end/testcases/rasta/type_literals.dart.dartk.expect View 1 chunk +0 lines, -97 lines 0 comments Download
D pkg/front_end/testcases/rasta/type_with_parse_error.dart.dartk.expect View 1 chunk +0 lines, -18 lines 0 comments Download
D pkg/front_end/testcases/rasta/typedef.dart.dartk.expect View 1 chunk +0 lines, -10 lines 0 comments Download
D pkg/front_end/testcases/rasta/unresolved.dart.dartk.expect View 1 chunk +0 lines, -7 lines 0 comments Download
D pkg/front_end/testcases/rasta/unresolved_constructor.dart.dartk.expect View 1 chunk +0 lines, -13 lines 0 comments Download
D pkg/front_end/testcases/rasta/unresolved_for_in.dart.dartk.expect View 1 chunk +0 lines, -53 lines 0 comments Download
D pkg/front_end/testcases/rasta/unresolved_recovery.dart.dartk.expect View 1 chunk +0 lines, -19 lines 0 comments Download
D pkg/front_end/testcases/rasta/unsupported_platform_library.dart.dartk.expect View 1 chunk +0 lines, -5 lines 0 comments Download
D pkg/front_end/testcases/regress/issue_29975.dart.dartk.expect View 1 chunk +0 lines, -7 lines 0 comments Download
D pkg/front_end/testcases/regress/issue_29983.dart.dartk.expect View 1 chunk +0 lines, -9 lines 0 comments Download
D pkg/front_end/testcases/regress/issue_29984.dart.dartk.expect View 1 chunk +0 lines, -8 lines 0 comments Download
D pkg/front_end/testcases/type_variable_as_super.dart.dartk.expect View 1 chunk +0 lines, -24 lines 0 comments Download
M pkg/front_end/tool/fasta_perf.dart View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Paul Berry
I only need a review from one of you.
3 years, 5 months ago (2017-07-13 19:05:14 UTC) #3
scheglov
LGTM
3 years, 5 months ago (2017-07-13 19:07:22 UTC) #4
Paul Berry
3 years, 5 months ago (2017-07-13 19:18:50 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
04ad043f49adf2e954a9eafc10d2f216c77debf3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698