Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 2980873003: Fix bug in writing deps file (Fixes #30156) (Closed)

Created:
3 years, 5 months ago by Siggi Cherem (dart-lang)
Modified:
3 years, 5 months ago
Reviewers:
zra
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix bug in writing deps file (Fixes #30156) Turns out the args were swapped, so we were writing one of our output files with the contents of the deps file. Later the script overrode that output file, so we didn't notice it. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/239c842b0563ef65d421273615eee1a0c2f1e86a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/patch_sdk.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Siggi Cherem (dart-lang)
3 years, 5 months ago (2017-07-13 18:39:32 UTC) #3
zra
lgtm
3 years, 5 months ago (2017-07-13 19:06:13 UTC) #4
Siggi Cherem (dart-lang)
3 years, 5 months ago (2017-07-13 19:09:51 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
239c842b0563ef65d421273615eee1a0c2f1e86a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698