Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Issue 2980863002: Fix MockSdk in analyzer for problems that cause exceptions in Fasta. (Closed)

Created:
3 years, 5 months ago by scheglov
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix MockSdk in analyzer for problems that cause exceptions in Fasta. R=ahe@google.com, paulberry@google.com, sigmund@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/125bd4cfed38f8fbbeaf703faf1512cc7964e97c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -10 lines) Patch
M pkg/analyzer/test/src/context/mock_sdk.dart View 6 chunks +7 lines, -10 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 5 months ago (2017-07-13 15:45:23 UTC) #1
Paul Berry
lgtm Are the exceptions due to bugs in Fasta? Should we file bug reports?
3 years, 5 months ago (2017-07-13 15:47:55 UTC) #2
scheglov
3 years, 5 months ago (2017-07-13 16:18:15 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
125bd4cfed38f8fbbeaf703faf1512cc7964e97c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698