Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 298083002: ui: Move font_list tests into gfx_unittests target. (Closed)

Created:
6 years, 7 months ago by tfarina
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

ui: Move font_list tests into gfx_unittests target. This test depends on the initialization of ResourceBundle, now that we have GfxTestSuite initializating it we can move it into gfx_unittests target. BUG=331829 TEST=ui_unittests, gfx_unittests TBR=danakj@chromium.org,ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272848

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M ui/gfx/gfx_tests.gyp View 2 chunks +2 lines, -0 lines 0 comments Download
M ui/ui_unittests.gyp View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
Looks like the GfxTestSuite change stuck. Proceeding... TBRing...(Ben, please, rubber stamp as Dana is OOO). ...
6 years, 7 months ago (2014-05-26 00:08:03 UTC) #1
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 7 months ago (2014-05-26 00:08:08 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/298083002/1
6 years, 7 months ago (2014-05-26 00:09:15 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-26 01:57:47 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-26 16:26:25 UTC) #5
Message was sent while issue was closed.
Change committed as 272848

Powered by Google App Engine
This is Rietveld 408576698