Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Unified Diff: runtime/vm/service_event.cc

Issue 2980733003: Introduced support for external services registration in the ServiceProtocol (Closed)
Patch Set: Address comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/service_event.h ('k') | sdk/lib/vmservice/client.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service_event.cc
diff --git a/runtime/vm/service_event.cc b/runtime/vm/service_event.cc
index 336d1594112984fb8806a6b1db7d6d47ab4471e0..5d7cc75851eb3359fd2cf588266e835e0d871126 100644
--- a/runtime/vm/service_event.cc
+++ b/runtime/vm/service_event.cc
@@ -111,8 +111,6 @@ const char* ServiceEvent::KindAsCString() const {
return "Extension";
case kTimelineEvents:
return "TimelineEvents";
- case kEditorObjectSelected:
- return "_EditorObjectSelected";
default:
UNREACHABLE();
return "Unknown";
@@ -164,9 +162,6 @@ const StreamInfo* ServiceEvent::stream_info() const {
case kEmbedder:
return NULL;
- case kEditorObjectSelected:
- return &Service::editor_stream;
-
default:
UNREACHABLE();
return NULL;
@@ -267,12 +262,6 @@ void ServiceEvent::PrintJSON(JSONStream* js) const {
js->AppendSerializedObject("extensionData",
extension_event_.event_data->ToCString());
}
- if (kind() == kEditorObjectSelected) {
- if (editor_event_.object != NULL) {
- jsobj.AddProperty("editor", editor_event_.editor);
- jsobj.AddProperty("object", *(editor_event_.object));
- }
- }
}
« no previous file with comments | « runtime/vm/service_event.h ('k') | sdk/lib/vmservice/client.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698