Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(559)

Unified Diff: runtime/observatory/lib/src/app/application.dart

Issue 2980733003: Introduced support for external services registration in the ServiceProtocol (Closed)
Patch Set: Address comments Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/observatory/lib/models.dart ('k') | runtime/observatory/lib/src/app/page.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/observatory/lib/src/app/application.dart
diff --git a/runtime/observatory/lib/src/app/application.dart b/runtime/observatory/lib/src/app/application.dart
index e6f11b627cca6409c23d8d157f6ca62bc6878718..345e7f0ea975d1ace06fc6cffa646d9294ce4d73 100644
--- a/runtime/observatory/lib/src/app/application.dart
+++ b/runtime/observatory/lib/src/app/application.dart
@@ -51,10 +51,16 @@ class ObservatoryApplication {
// Mark that we haven't connected yet.
_vmConnected = false;
// On connect:
- newVM.onConnect.then((_) {
+ newVM.onConnect.then((_) async {
// We connected.
_vmConnected = true;
notifications.deleteDisconnectEvents();
+ await newVM.load();
+ // TODO(cbernaschina) smart connection of streams in the events object.
+ newVM.listenEventStream(VM.kVMStream, _onEvent);
+ newVM.listenEventStream(VM.kIsolateStream, _onEvent);
+ newVM.listenEventStream(VM.kDebugStream, _onEvent);
+ newVM.listenEventStream(VM.kServiceStream, _onEvent);
});
// On disconnect:
newVM.onDisconnect.then((String reason) {
@@ -78,10 +84,6 @@ class ObservatoryApplication {
events.add(new ConnectionClosedEvent(new DateTime.now(), reason));
}
});
- // TODO(cbernaschina) smart connection of streams in the events object.
- newVM.listenEventStream(VM.kVMStream, _onEvent);
- newVM.listenEventStream(VM.kIsolateStream, _onEvent);
- newVM.listenEventStream(VM.kDebugStream, _onEvent);
}
_vm = newVM;
« no previous file with comments | « runtime/observatory/lib/models.dart ('k') | runtime/observatory/lib/src/app/page.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698