Reuse WebCrypto's normalizeCryptoAlgorithm in enterprise.platformKeys.

chrome/test/data/extensions/api_test/enterprise_platform_keys/basic.js

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Must be packed to ../enterprise_platform_keys.crx using the private key
 // ../enterprise_platform_keys.pem .
 
 var assertEq = chrome.test.assertEq;
 var assertTrue = chrome.test.assertTrue;
 var assertThrows = chrome.test.assertThrows;
@@ skipping 283 matching lines @@
                   assertTrue(!!keyPair, "No key pair.");
                   cachedKeyPair = keyPair;
                   return userToken.subtleCrypto.exportKey('spki',
                                                           keyPair.publicKey);
                 }),
                 function(error) {
             assertTrue(false, "GenerateKey failed: " + error);
           })
           .then(callbackPass(function(publicKeySpki) {
                   cachedSpki = publicKeySpki;
+                  var signParams = {name: 'RSASSA-PKCS1-v1_5'};
                   return userToken.subtleCrypto.sign(
-                      {}, cachedKeyPair.privateKey, data);
+                      signParams, cachedKeyPair.privateKey, data);
                 }),
                 function(error) {
             assertTrue(false, "Export failed: " + error);
           })
           .then(callbackPass(function(signature) {
                   assertTrue(!!signature, "No signature.");
                   assertTrue(signature.length != 0, "Signature is empty.");
                   cachedSignature = signature;
                   return window.crypto.subtle.importKey(
                       "spki", cachedSpki, algorithm, false, ["verify"]);
@@ skipping 35 matching lines @@
         assertCertsStored.bind(null, userToken, [cert1a, cert1b]),
         chrome.enterprise.platformKeys.removeCertificate.bind(
             null, userToken.id, cert1a.buffer),
         assertCertsStored.bind(null, userToken, [cert1b]),
         chrome.enterprise.platformKeys.removeCertificate.bind(
             null, userToken.id, cert1b.buffer),
         assertCertsStored.bind(null, userToken, [])
       ]);
     },
 
+    // Call generate key with invalid algorithm parameter, missing
+    // modulusLength.
+    function algorithmParameterMissingModulusLength() {
+      var algorithm = {
+        name: "RSASSA-PKCS1-v1_5",
+        publicExponent:
+            new Uint8Array([0x01, 0x00, 0x01]),  // Equivalent to 65537
+        hash: {
+          name: "SHA-1",
+        }
+      };
+      userToken.subtleCrypto.generateKey(algorithm, false, ['sign']).then(
+          function(keyPair) {
+            assertTrue(false, 'generateKey was expected to fail');
+          },
+          callbackPass(function(error) {
+      assertEq(
+          new Error('Error: A required parameter was missing our out-of-range'),

[eroman, 2014/06/05 23:38:28]

our --> or

[pneubeck (no reviews), 2014/06/06 12:39:45]

Done.

+          error);
+      }));
+    },
+
+    // Call generate key with invalid algorithm parameter, missing hash.
+    function algorithmParameterMissingHash() {
+      var algorithm = {
+        name: 'RSASSA-PKCS1-v1_5',
+        modulusLength: 512,
+        publicExponent:
+            new Uint8Array([0x01, 0x00, 0x01]),  // Equivalent to 65537
+      };
+      userToken.subtleCrypto.generateKey(algorithm, false, ['sign']).then(
+          function(keyPair) {
+            assertTrue(false, 'generateKey was expected to fail');
+          },
+          callbackPass(function(error) {
+      assertEq(
+          new Error('Error: A required parameter was missing our out-of-range'),

[eroman, 2014/06/05 23:38:28]

our --> or

[pneubeck (no reviews), 2014/06/06 12:39:45]

Done.

+          error);
+      }));
+    },
+
     // Imports a certificate for which now private key was imported/generated
     // before.
     function missingPrivateKey() {
       chrome.enterprise.platformKeys.importCertificate(
           userToken.id, cert2.buffer, callbackFail('Key not found.'));
     },
     function importInvalidCert() {
       var invalidCert = new ArrayBuffer(16);
       chrome.enterprise.platformKeys.importCertificate(
           userToken.id,
@@ skipping 14 matching lines @@
           callbackFail('Certificate is not a valid X.509 certificate.'));
     },
     function getCertsInvalidToken() {
       chrome.enterprise.platformKeys.getCertificates(
           'invalid token id', callbackFail('The token is not valid.'));
     }
   ]);
 }
 
 beforeTests(runTests);