Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Issue 2980653002: Don't include *.yaml files in 'analysis.analyzedFiles' notification. (Closed)

Created:
3 years, 5 months ago by scheglov
Modified:
3 years, 5 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, lukeechurch_gmail.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't include *.yaml files in 'analysis.analyzedFiles' notification. R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/78f78feaf813120a0c2ef06733ec4aa887e346f9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M pkg/analysis_server/lib/src/operation/operation_analysis.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/analysis/notification_analyzedFiles_test.dart View 3 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 5 months ago (2017-07-11 21:05:33 UTC) #1
jwren
On 2017/07/11 21:05:33, scheglov wrote: LGTM
3 years, 5 months ago (2017-07-11 21:12:00 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 78f78feaf813120a0c2ef06733ec4aa887e346f9 (presubmit successful).
3 years, 5 months ago (2017-07-11 21:19:21 UTC) #4
Brian Wilkerson
3 years, 5 months ago (2017-07-19 17:12:38 UTC) #5
Message was sent while issue was closed.
My expectation is that `analysis.analyzedFiles` would be used by clients to know
which files should be considered priority files when opened and which files to
send content overlay for. (If that isn't the case, then what is it being used
for?)

We are adding support for analyzing analysis options files. I would like clients
to know to send content overlays for these files, so, if my assumption above is
correct, I want them to be included in the notification.

I also have concerns about the potential implications of this approach for our
plugin support.

It seems to me that a better solution would be to put this filter in the
IntelliJ plugin rather than in server, given that IntelliJ is using this
information for a non-generic purpose.

Powered by Google App Engine
This is Rietveld 408576698