Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Unified Diff: chrome/browser/browser_process_impl.cc

Issue 298063006: Make SdchManager per-profile. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Make access to sdch manager in tests go through an accessor." Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/io_thread.cc » ('j') | chrome/browser/net/sdch_dictionary_fetcher.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser_process_impl.cc
diff --git a/chrome/browser/browser_process_impl.cc b/chrome/browser/browser_process_impl.cc
index 33969aaf631aae482474aa6f8ae5bfbc036b88c9..9c550863d04b4b457e91ebe360146b141d3b0b9f 100644
--- a/chrome/browser/browser_process_impl.cc
+++ b/chrome/browser/browser_process_impl.cc
@@ -201,13 +201,6 @@ BrowserProcessImpl::~BrowserProcessImpl() {
void BrowserProcessImpl::StartTearDown() {
TRACE_EVENT0("shutdown", "BrowserProcessImpl::StartTearDown");
- // We need to shutdown the SdchDictionaryFetcher as it regularly holds
- // a pointer to a URLFetcher, and that URLFetcher (upon destruction) will do
- // a PostDelayedTask onto the IO thread. This shutdown call will both discard
- // any pending URLFetchers, and avoid creating any more.
- BrowserThread::PostTask(BrowserThread::IO, FROM_HERE,
- base::Bind(&SdchDictionaryFetcher::Shutdown));
-
// We need to destroy the MetricsServicesManager, IntranetRedirectDetector,
// PromoResourceService, and SafeBrowsing ClientSideDetectionService (owned by
// the SafeBrowsingService) before the io_thread_ gets destroyed, since their
« no previous file with comments | « no previous file | chrome/browser/io_thread.cc » ('j') | chrome/browser/net/sdch_dictionary_fetcher.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698