Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Unified Diff: net/filter/sdch_filter.h

Issue 298063006: Make SdchManager per-profile. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed bugs found through smoke testing and incorporated comments. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/filter/mock_filter_context.cc ('k') | net/filter/sdch_filter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/filter/sdch_filter.h
diff --git a/net/filter/sdch_filter.h b/net/filter/sdch_filter.h
index 5b401e464e8933b840463f450a94884fd4714157..325f0af3119edad21f090080f860a772ef1eaaa8 100644
--- a/net/filter/sdch_filter.h
+++ b/net/filter/sdch_filter.h
@@ -95,6 +95,13 @@ class NET_EXPORT_PRIVATE SdchFilter : public Filter {
// That char* data is part of the dictionary_ we hold a reference to.
scoped_refptr<SdchManager::Dictionary> dictionary_;
+ // We keep a copy of the URLRequestContext for use in the destructor, (at
+ // which point GetURLRequestContext() will likely return null because of
+ // the disassociation of the URLRequest from the URLRequestJob). This is
+ // safe because the URLRequestJob (and any filters) are guaranteed to be
+ // deleted before the URLRequestContext is destroyed.
+ const URLRequestContext * const url_request_context_;
jar (doing other things) 2014/06/13 18:28:48 nit: no space before the asterisk. (like lines 43,
Randy Smith (Not in Mondays) 2014/06/13 19:40:12 Whoops; done.
+
// The decoder may demand a larger output buffer than the target of
// ReadFilteredData so we buffer the excess output between calls.
std::string dest_buffer_excess_;
« no previous file with comments | « net/filter/mock_filter_context.cc ('k') | net/filter/sdch_filter.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698