Make SdchManager per-profile.

chrome/browser/net/sdch_dictionary_fetcher.h

Index: chrome/browser/net/sdch_dictionary_fetcher.h
diff --git a/chrome/browser/net/sdch_dictionary_fetcher.h b/chrome/browser/net/sdch_dictionary_fetcher.h
index 96617438fb90477afbfca891aebd4e64e1d7f51b..e69ec69eab09a5abd22e28a1247836a5cb3f497f 100644
--- a/chrome/browser/net/sdch_dictionary_fetcher.h
+++ b/chrome/browser/net/sdch_dictionary_fetcher.h
@@ -29,13 +29,13 @@ class SdchDictionaryFetcher
       public net::SdchFetcher,
       public base::NonThreadSafe {
  public:
-  explicit SdchDictionaryFetcher(net::URLRequestContextGetter* context);
+  // Consumer must guarantee that the SdchManager pointer outlives
+  // this object.  Usually this is done by making sure the manager
+  // owns this object.
+  SdchDictionaryFetcher(net::SdchManager* manager,
+                        net::URLRequestContextGetter* context);
   virtual ~SdchDictionaryFetcher();
 
-  // Stop fetching dictionaries, and abandon any current URLFetcheer operations
-  // so that the IO thread can be stopped.
-  static void Shutdown();

[jar (doing other things), 2014/05/27 17:53:09]

Given that the dictionary fetch is very async... I would expect that you'll need
some shutdown call to abandon such a pending fetch.

[Randy Smith (Not in Mondays), 2014/06/04 22:04:52]

I believe what I currently have is equivalent to the old global code with regard
to shutdown; do you disagree with that claim, or do you think that I need to add
something to shutdown pending fetches that wasn't in the original code?

Support for above statements: In the original code,
BrowserProcessImpl::StartTearDown called SdchDictionaryFetcher::Shutdown(),
which called SdchManager::Shutdown(), which reset the SdchDictionaryFetcher
scoped_ptr<> to null, which triggered the SdchDictionaryFetcher() destructor. 
In the current code, when the ProfileImplIOData is torn down (which I think is
before BrowserProcessImpl::StartTearDown, as it's per-profile), that results in
SdchManager destruction, which will result in SdchFetcher scoped_ptr<> nulling,
which will result in SdchDictionaryFetcher destruction.

I believe that SdchDictionaryFetcher destruction results in cancellation, since
it results in URLFetcher destruction, which results in calling
URLFetcherCore::Stop().

-
   // Implementation of SdchFetcher class.
   // This method gets the requested dictionary, and then calls back into the
   // SdchManager class with the dictionary's text.
@@ -59,6 +59,8 @@ class SdchDictionaryFetcher
   // completes (either successfully or with failure).
   virtual void OnURLFetchComplete(const net::URLFetcher* source) OVERRIDE;
 
+  net::SdchManager* manager_;
+
   // A queue of URLs that are being used to download dictionaries.
   std::queue<GURL> fetch_queue_;
   // The currently outstanding URL fetch of a dicitonary.