Make SdchManager per-profile.

net/filter/mock_filter_context.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_FILTER_MOCK_FILTER_CONTEXT_H_
 #define NET_FILTER_MOCK_FILTER_CONTEXT_H_
 
 #include <string>
 
+#include "base/memory/scoped_ptr.h"
 #include "net/filter/filter.h"
 #include "url/gurl.h"
 
 namespace net {
 
+class URLRequestContext;
+
 class MockFilterContext : public FilterContext {
  public:
   MockFilterContext();
   virtual ~MockFilterContext();
 
   void SetMimeType(const std::string& mime_type) { mime_type_ = mime_type; }
   void SetURL(const GURL& gurl) { gurl_ = gurl; }
   void SetContentDisposition(const std::string& disposition) {
     content_disposition_ = disposition;
   }
   void SetRequestTime(const base::Time time) { request_time_ = time; }
   void SetCached(bool is_cached) { is_cached_content_ = is_cached; }
   void SetDownload(bool is_download) { is_download_ = is_download; }
   void SetResponseCode(int response_code) { response_code_ = response_code; }
   void SetSdchResponse(bool is_sdch_response) {
     is_sdch_response_ = is_sdch_response;
   }
+  URLRequestContext* GetModifiableURLRequestContext() { return context_.get(); }

[jar (doing other things), 2014/06/09 23:03:01]

nit: nice to use const on such accessors.

[Randy Smith (Not in Mondays), 2014/06/10 20:38:41]

Actually, the whole point of this accessor is that it's not const; thus the
"Modifiable" portion of the accessor name.  The const version is part of the
base class, and is declared below.  This accessor is used to set the SdchManager
on the URLRequestContext, so I didn't think it was reasonable to make it const. 
But I'm interested in an alternate perspective if you'd like to pitch it.

[jar (doing other things), 2014/06/11 20:04:43]

I wasn't asking for the return value to be const, but rather the method to be
noted as const (i.e., this call does not change the instance's state):

URLRequestContext* GetModifiableURLRequestContext() const {
  return context_.get();
}

Quoting from the style guide:
"Declare methods to be const whenever possible. Accessors should almost always
be const. "

...or am I misunderstanding??

[Randy Smith (Not in Mondays), 2014/06/11 20:43:37]

Sorry, another const parsing braino.  Done.

 
   virtual bool GetMimeType(std::string* mime_type) const OVERRIDE;
 
   // What URL was used to access this data?
   // Return false if gurl is not present.
   virtual bool GetURL(GURL* gurl) const OVERRIDE;
 
   // What Content-Disposition did the server supply for this data?
   // Return false if Content-Disposition was not present.
   virtual bool GetContentDisposition(std::string* disposition) const OVERRIDE;
 
   // What was this data requested from a server?
   virtual base::Time GetRequestTime() const OVERRIDE;
 
   // Is data supplied from cache, or fresh across the net?
   virtual bool IsCachedContent() const OVERRIDE;
 
   // Is this a download?
   virtual bool IsDownload() const OVERRIDE;
 
   // Was this data flagged as a response to a request with an SDCH dictionary?
   virtual bool IsSdchResponse() const OVERRIDE;
 
   // How many bytes were fed to filter(s) so far?
   virtual int64 GetByteReadCount() const OVERRIDE;
 
   virtual int GetResponseCode() const OVERRIDE;
 
+  // The URLRequestContext associated with the request.
+  virtual const URLRequestContext* GetURLRequestContext() const OVERRIDE;
+
   virtual void RecordPacketStats(StatisticSelector statistic) const OVERRIDE {}
 
  private:
   int buffer_size_;
   std::string mime_type_;
   std::string content_disposition_;
   GURL gurl_;
   base::Time request_time_;
   bool is_cached_content_;
   bool is_download_;
   bool is_sdch_response_;
   int response_code_;
+  scoped_ptr<URLRequestContext> context_;
 
   DISALLOW_COPY_AND_ASSIGN(MockFilterContext);
 };
 
 }  // namespace net
 
 #endif  // NET_FILTER_MOCK_FILTER_CONTEXT_H_