Make SdchManager per-profile.

chrome/browser/profiles/profile_impl_io_data.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_impl_io_data.h"
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/logging.h"
 #include "base/metrics/field_trial.h"
 #include "base/prefs/pref_member.h"
 #include "base/prefs/pref_service.h"
 #include "base/sequenced_task_runner.h"
 #include "base/stl_util.h"
 #include "base/strings/string_util.h"
 #include "base/threading/sequenced_worker_pool.h"
 #include "base/threading/worker_pool.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/chromeos/profiles/profile_helper.h"
 #include "chrome/browser/custom_handlers/protocol_handler_registry.h"
 #include "chrome/browser/custom_handlers/protocol_handler_registry_factory.h"
 #include "chrome/browser/io_thread.h"
 #include "chrome/browser/net/chrome_net_log.h"
 #include "chrome/browser/net/chrome_network_delegate.h"
 #include "chrome/browser/net/connect_interceptor.h"
 #include "chrome/browser/net/cookie_store_util.h"
 #include "chrome/browser/net/http_server_properties_manager.h"
 #include "chrome/browser/net/predictor.h"
+#include "chrome/browser/net/sdch_dictionary_fetcher.h"
 #include "chrome/browser/net/sqlite_server_bound_cert_store.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/common/url_constants.h"
 #include "components/domain_reliability/monitor.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/cookie_store_factory.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/resource_context.h"
 #include "content/public/browser/storage_partition.h"
 #include "extensions/browser/extension_protocols.h"
 #include "extensions/common/constants.h"
 #include "net/base/cache_type.h"
+#include "net/base/sdch_manager.h"
 #include "net/ftp/ftp_network_layer.h"
 #include "net/http/http_cache.h"
 #include "net/ssl/server_bound_cert_service.h"
 #include "net/url_request/url_request_job_factory_impl.h"
 #include "webkit/browser/quota/special_storage_policy.h"
 
 #if defined(OS_ANDROID) || defined(OS_IOS)
 #if defined(SPDY_PROXY_AUTH_VALUE)
 #include "components/data_reduction_proxy/browser/data_reduction_proxy_settings.h"
 #endif
@@ skipping 461 matching lines @@
       request_interceptors.Pass(),
       profile_params->protocol_handler_interceptor.Pass(),
       network_delegate(),
       ftp_factory_.get());
   main_context->set_job_factory(main_job_factory_.get());
 
 #if defined(ENABLE_EXTENSIONS)
   InitializeExtensionsRequestContext(profile_params);
 #endif
 
+  // Setup the SDCHManager for this profile.
+  sdch_manager_.reset(new net::SdchManager);
+  sdch_manager_->set_sdch_fetcher(
+      new SdchDictionaryFetcher(
+          sdch_manager_.get(),
+          // SdchDictionaryFetcher takes a reference to the Getter, and
+          // hence implicitly takes ownership.
+          new net::TrivialURLRequestContextGetter(

[mmenke, 2014/06/12 16:48:31]

This makes me sad, but doing something nicer seems beyond the scope of this CL.

[Randy Smith (Not in Mondays), 2014/06/12 18:06:40]

I chatted with Will as to whether or not this should be considered a reasonable
idiom, and his opinion was that it was a reasonable idiom
(https://codereview.chromium.org/292063002).  I don't know if that increases or
decreases your sadness :-}.

The "something nicer" would be to rewrite the dictionary fetcher to use
URLRequest rather than URLFetcher, which is a good idea for a couple of reasons,
not just this one.  But I suspect you understand why I don't want it on my
critical path :-J.

[mmenke, 2014/06/12 18:11:16]

Actually, I'd be fine with using the real main request context getter - my issue
here is just with creating another one.  I'm fine with using URLFetcher for this
(For some value of "fine" - URLFetchers don't, by default, limit body sizes, so
anyone who feels like crashing Chrome may be able to do so).

+              main_context,
+              content::BrowserThread::GetMessageLoopProxyForThread(
+                  content::BrowserThread::IO))));

[mmenke, 2014/06/12 16:48:31]

Shouldn't you be calling main_context.set_sdch_manager?

[mmenke, 2014/06/12 16:48:31]

What about the OTR profile?  It would end up using the in-memory cache, so I
think it would be safe to give its own manager, I assume.

[Randy Smith (Not in Mondays), 2014/06/12 18:06:39]

Tricky question.  I think the answer for this CL is "yes", but there's a privacy
issue that'll show up coming down the pike around this.  We're going to need to
limit memory consumed by SDCH on a global basis (http://crbug.com/374917) and
that'll provide some information leakage between profiles.  But I'll worry about
this issue at that point.  Done.

[Randy Smith (Not in Mondays), 2014/06/12 18:06:39]

Yikes.  Thank you.  Yes.  (And I won't land without at least smoke testing. 
This is a refactor, so I didn't add any tests, but SDCH clearly needs a browser
test.)

+
   // Create a media request context based on the main context, but using a
   // media cache.  It shares the same job factory as the main context.
   StoragePartitionDescriptor details(profile_path_, false);
   media_request_context_.reset(InitializeMediaRequestContext(main_context,
                                                              details));
 
   if (IsDomainReliabilityMonitoringEnabled()) {
     domain_reliability_monitor_.reset(
         new domain_reliability::DomainReliabilityMonitor(
             main_context, kDomainReliabilityUploadReporterString));
@@ skipping 239 matching lines @@
     domain_reliability::DomainReliabilityClearMode mode,
     const base::Closure& completion) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
   DCHECK(initialized());
 
   if (domain_reliability_monitor_)
     domain_reliability_monitor_->ClearBrowsingData(mode);
 
   BrowserThread::PostTask(BrowserThread::UI, FROM_HERE, completion);
 }