Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2980553002: Option --limit-ints-to-64-bits should be included into product (Closed)

Created:
3 years, 5 months ago by alexmarkov
Modified:
3 years, 5 months ago
Reviewers:
zra, regis, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Option --limit-ints-to-64-bits should be included into product The option should be present in PRODUCT mode because it is used in the test runtime/tests/vm/dart/truncating_ints_test.dart (in the VMOptions specification). R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/7360dd42ee83431f4e8f7aa2a565f0ea487832af

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M runtime/vm/flag_list.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
alexmarkov
3 years, 5 months ago (2017-07-10 22:41:58 UTC) #2
siva
lgtm
3 years, 5 months ago (2017-07-10 22:43:52 UTC) #3
alexmarkov
3 years, 5 months ago (2017-07-10 22:44:32 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7360dd42ee83431f4e8f7aa2a565f0ea487832af (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698