Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 298053002: Oilpan: add missing HTMLFormControlsCollection tracing. (Closed)

Created:
6 years, 7 months ago by sof
Modified:
6 years, 7 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Oilpan: add missing HTMLFormControlsCollection tracing. R=haraken@chromium.org BUG=357163 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174765

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M Source/core/html/HTMLFormControlsCollection.h View 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/html/HTMLFormControlsCollection.cpp View 3 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
sof
Please take a look.
6 years, 7 months ago (2014-05-24 07:05:03 UTC) #1
haraken
LGTM
6 years, 7 months ago (2014-05-24 07:15:03 UTC) #2
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 7 months ago (2014-05-24 08:04:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/298053002/1
6 years, 7 months ago (2014-05-24 08:05:07 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-24 08:39:25 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-24 08:57:54 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/8875)
6 years, 7 months ago (2014-05-24 08:57:54 UTC) #7
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 7 months ago (2014-05-24 12:43:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/298053002/1
6 years, 7 months ago (2014-05-24 12:44:01 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-24 13:43:35 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-24 14:26:06 UTC) #11
Message was sent while issue was closed. 
Change committed as 174765

Powered by Google App Engine
This is Rietveld 408576698