Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(503)

Issue 2980513002: Add native extension to flutter targets (this was removed accidentally in an (Closed)

Created:
3 years, 5 months ago by Siggi Cherem (dart-lang)
Modified:
3 years, 5 months ago
Reviewers:
zra, ahe
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add native extension to flutter targets (this was removed accidentally in an earlier CL, I had assumed flutter targets simply extended the VM targets). Fixes #30118 R=ahe@google.com, zra@google.com Committed: https://github.com/dart-lang/sdk/commit/c720c776e0402c812d6a80961e9c3081b2adbe10

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M pkg/kernel/lib/target/flutter.dart View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Siggi Cherem (dart-lang)
3 years, 5 months ago (2017-07-10 17:49:18 UTC) #1
zra
lgtm
3 years, 5 months ago (2017-07-10 17:51:03 UTC) #2
Siggi Cherem (dart-lang)
3 years, 5 months ago (2017-07-10 17:55:40 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
c720c776e0402c812d6a80961e9c3081b2adbe10 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698