Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(616)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2980483002: Modify environment binding to bind variable declarations to locations (Closed)

Created:
3 years, 5 months ago by zhivkag
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Modify environment binding to bind variable declarations to locations BUG= R=dmitryas@google.com Committed: https://github.com/dart-lang/sdk/commit/8e52eea681e3d5cb282e407549621fd95d6bb45a

Patch Set 1 #

Patch Set 2 : Make location final #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -5 lines) Patch
M pkg/kernel/lib/interpreter/interpreter.dart View 1 2 chunks +11 lines, -5 lines 0 comments Download

Dependent Patchsets:

Issue 2975893002 Patch 1

Messages

Total messages: 7 (4 generated)
zhivkag
3 years, 5 months ago (2017-07-11 07:11:56 UTC) #2
Dmitry Stefantsov
LGTM
3 years, 5 months ago (2017-07-13 07:40:59 UTC) #5
zhivkag
3 years, 5 months ago (2017-07-13 07:54:55 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
8e52eea681e3d5cb282e407549621fd95d6bb45a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698