[Oilpan]: Move HTMLStackItem and friends to the oilpan heap.

[Oilpan]: Move HTMLStackItem and friends to the oilpan heap.

This change moves the HTMLStackItem to the oilpan heap. This removes a RefPtr from HTMLStackItem into the Node hierarchy which was/is causing a leak when we stop calling dispose from the Document's detach method.

R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174953

[Mads Ager (chromium), 2014-05-27 10:32:03]

LGTM

https://codereview.chromium.org/298043008/diff/20001/Source/core/html/parser/...
File Source/core/html/parser/HTMLElementStack.h (right):

https://codereview.chromium.org/298043008/diff/20001/Source/core/html/parser/...
Source/core/html/parser/HTMLElementStack.h:53: class ElementRecord : public
NoBaseWillBeGarbageCollected<ElementRecord> {
add FINAL since the trace method is not virtual?

[wibling-chromium, 2014-05-27 10:45:45]

Thanks for the review!

https://codereview.chromium.org/298043008/diff/20001/Source/core/html/parser/...
File Source/core/html/parser/HTMLElementStack.h (right):

https://codereview.chromium.org/298043008/diff/20001/Source/core/html/parser/...
Source/core/html/parser/HTMLElementStack.h:53: class ElementRecord : public
NoBaseWillBeGarbageCollected<ElementRecord> {
On 2014/05/27 10:32:03, Mads Ager (chromium) wrote:
> add FINAL since the trace method is not virtual?

Done.

[haraken, 2014-05-27 10:48:22]

LGTM.

https://codereview.chromium.org/298043008/diff/20001/Source/core/html/parser/...
File Source/core/html/parser/HTMLElementStack.h (right):

https://codereview.chromium.org/298043008/diff/20001/Source/core/html/parser/...
Source/core/html/parser/HTMLElementStack.h:58: #endif

You can use DECLARE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED

https://codereview.chromium.org/298043008/diff/20001/Source/core/html/parser/...
Source/core/html/parser/HTMLElementStack.h:188: Element* m_bodyElement;

Shall we make these pointers Members? I'm not really happy with leaving raw
pointers in on-heap objects :)

https://codereview.chromium.org/298043008/diff/20001/Source/core/html/parser/...
File Source/core/html/parser/HTMLStackItem.h (right):

https://codereview.chromium.org/298043008/diff/20001/Source/core/html/parser/...
Source/core/html/parser/HTMLStackItem.h:42: class HTMLStackItem : public
RefCountedWillBeGarbageCollectedFinalized<HTMLStackItem> {

Add FINAL.

https://codereview.chromium.org/298043008/diff/20001/Source/core/html/parser/...
File Source/core/html/parser/HTMLTreeBuilder.h (right):

https://codereview.chromium.org/298043008/diff/20001/Source/core/html/parser/...
Source/core/html/parser/HTMLTreeBuilder.h:212: DocumentFragment* m_fragment;

You can make this a Member as well.

[wibling-chromium, 2014-05-27 11:16:36]

https://codereview.chromium.org/298043008/diff/20001/Source/core/html/parser/...
File Source/core/html/parser/HTMLElementStack.h (right):

https://codereview.chromium.org/298043008/diff/20001/Source/core/html/parser/...
Source/core/html/parser/HTMLElementStack.h:58: #endif
On 2014/05/27 10:48:22, haraken wrote:
> 
> You can use DECLARE_EMPTY_DESTRUCTOR_WILL_BE_REMOVED

I tried it, but it doesn't work since it is a nested class so it expands
incorrectly.

https://codereview.chromium.org/298043008/diff/20001/Source/core/html/parser/...
Source/core/html/parser/HTMLElementStack.h:188: Element* m_bodyElement;
On 2014/05/27 10:48:22, haraken wrote:
> 
> Shall we make these pointers Members? I'm not really happy with leaving raw
> pointers in on-heap objects :)

Done.

https://codereview.chromium.org/298043008/diff/20001/Source/core/html/parser/...
File Source/core/html/parser/HTMLStackItem.h (right):

https://codereview.chromium.org/298043008/diff/20001/Source/core/html/parser/...
Source/core/html/parser/HTMLStackItem.h:42: class HTMLStackItem : public
RefCountedWillBeGarbageCollectedFinalized<HTMLStackItem> {
On 2014/05/27 10:48:22, haraken wrote:
> 
> Add FINAL.

Done.

https://codereview.chromium.org/298043008/diff/20001/Source/core/html/parser/...
File Source/core/html/parser/HTMLTreeBuilder.h (right):

https://codereview.chromium.org/298043008/diff/20001/Source/core/html/parser/...
Source/core/html/parser/HTMLTreeBuilder.h:212: DocumentFragment* m_fragment;
On 2014/05/27 10:48:22, haraken wrote:
> 
> You can make this a Member as well.

Done.

[zerny-chromium, 2014-05-27 11:23:07]

lgtm

[wibling-chromium, 2014-05-27 11:26:59]

The CQ bit was checked by wibling@chromium.org

[commit-bot: I haz the power, 2014-05-27 11:27:04]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wibling@chromium.org/298043008/2

[commit-bot: I haz the power, 2014-05-27 12:40:14]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/9242)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/12437)

[commit-bot: I haz the power, 2014-05-27 13:14:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-27 13:14:23]

Try jobs failed on following builders:
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/12454)

[wibling-chromium, 2014-05-28 08:40:44]

The CQ bit was checked by wibling@chromium.org

[commit-bot: I haz the power, 2014-05-28 08:41:02]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/wibling@chromium.org/298043008/50001

[commit-bot: I haz the power, 2014-05-28 09:57:52]

Change committed as 174953