Source/core/css/CSSComputedStyleDeclaration.cpp - Issue 298043007: Support unknown property strings in transition-property

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSComputedStyleDeclaration.cpp

Issue 298043007: Support unknown property strings in transition-property (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/transitions/transitions-parsing-expected.txt ('K') | « Source/core/animation/css/CSSTransitionData.h ('k') | Source/core/css/StylePropertyShorthandCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/CSSComputedStyleDeclaration.cpp

diff --git a/Source/core/css/CSSComputedStyleDeclaration.cpp b/Source/core/css/CSSComputedStyleDeclaration.cpp

index 1a4009cafe31734b91b6bcdd2f8b87c2881f9fa4..8c391e5323c434e63cdea5f322f53faa966dc949 100644

--- a/Source/core/css/CSSComputedStyleDeclaration.cpp

+++ b/Source/core/css/CSSComputedStyleDeclaration.cpp

@@ -937,12 +937,14 @@ static PassRefPtrWillBeRawPtr<CSSValue> valueForGridPosition(const GridPosition&

return list;

}

-static PassRefPtrWillBeRawPtr<CSSValue> createTransitionPropertyValue(CSSTransitionData::TransitionProperty property)

+static PassRefPtrWillBeRawPtr<CSSValue> createTransitionPropertyValue(const CSSTransitionData::TransitionProperty& property)

{

if (property.propertyType == CSSTransitionData::TransitionNone)

return cssValuePool().createIdentifierValue(CSSValueNone);

if (property.propertyType == CSSTransitionData::TransitionAll)

return cssValuePool().createIdentifierValue(CSSValueAll);

+ if (property.propertyType == CSSTransitionData::TransitionUnknown)

+ return cssValuePool().createValue(property.propertyString, CSSPrimitiveValue::CSS_STRING);

ASSERT(property.propertyType == CSSTransitionData::TransitionSingleProperty);

return cssValuePool().createValue(getPropertyNameString(property.propertyId), CSSPrimitiveValue::CSS_STRING);

}