Source/core/animation/css/CSSAnimations.cpp - Issue 298043007: Support unknown property strings in transition-property

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/css/CSSAnimations.cpp

Issue 298043007: Support unknown property strings in transition-property (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/transitions/transitions-parsing-expected.txt ('K') | « LayoutTests/transitions/transitions-parsing-expected.txt ('k') | Source/core/animation/css/CSSTransitionData.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/animation/css/CSSAnimations.cpp

diff --git a/Source/core/animation/css/CSSAnimations.cpp b/Source/core/animation/css/CSSAnimations.cpp

index 97267651e26b2b09e91f78817d15ce1e4057c42e..ee242c18f86664b0c523c7128cf528cfc96990d2 100644

--- a/Source/core/animation/css/CSSAnimations.cpp

+++ b/Source/core/animation/css/CSSAnimations.cpp

@@ -477,7 +477,7 @@ void CSSAnimations::calculateTransitionUpdate(CSSAnimationUpdate* update, const

const CSSTransitionData::TransitionProperty& transitionProperty = transitionData->propertyList()[i];

CSSTransitionData::TransitionPropertyType mode = transitionProperty.propertyType;

CSSPropertyID property = transitionProperty.propertyId;

- if (mode == CSSTransitionData::TransitionNone)

+ if (mode == CSSTransitionData::TransitionNone || mode == CSSTransitionData::TransitionUnknown)

continue;

bool animateAll = mode == CSSTransitionData::TransitionAll;