Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 2980293002: Added test using void in new positions. (Closed)

Created:
3 years, 5 months ago by eernst
Modified:
3 years, 5 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, floitsch
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Added test using void in new positions. This is the first step of addressing issue 30176. The test contains syntax errors according to all tools, and status files have been adjusted accordingly. R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/182c4d5923fce1ecc97254a4770a48d4a11c0f23

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+112 lines, -0 lines) Patch
A tests/language/generalized_void_syntax_test.dart View 1 chunk +105 lines, -0 lines 0 comments Download
M tests/language/language.status View 1 chunk +1 line, -0 lines 0 comments Download
M tests/language/language_analyzer2.status View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/language_dart2js.status View 1 chunk +2 lines, -0 lines 0 comments Download
M tests/language/language_kernel.status View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
eernst
3 years, 5 months ago (2017-07-18 11:03:05 UTC) #2
Johnni Winther
lgtm
3 years, 5 months ago (2017-07-18 11:20:41 UTC) #3
eernst
3 years, 5 months ago (2017-07-18 11:27:38 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
182c4d5923fce1ecc97254a4770a48d4a11c0f23.

Powered by Google App Engine
This is Rietveld 408576698