Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1300)

Unified Diff: pkg/front_end/lib/src/base/processed_options.dart

Issue 2980273002: Random improvements in error reporting. (Closed)
Patch Set: rebased Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/front_end/lib/src/fasta/fasta_codes_generated.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/src/base/processed_options.dart
diff --git a/pkg/front_end/lib/src/base/processed_options.dart b/pkg/front_end/lib/src/base/processed_options.dart
index 27c7799b7cd555b478b93370d825139f5c006013..ea1d6ac526b132e1c77ef3fecc461f75f8c43489 100644
--- a/pkg/front_end/lib/src/base/processed_options.dart
+++ b/pkg/front_end/lib/src/base/processed_options.dart
@@ -173,7 +173,7 @@ class ProcessedOptions {
source.scheme != 'packages' &&
!await fileSystem.entityForUri(source).exists()) {
reportWithoutLocation(
- templateInputFileNotFound.withArguments('$source'), Severity.error);
+ templateInputFileNotFound.withArguments(source), Severity.error);
return false;
}
}
@@ -181,21 +181,20 @@ class ProcessedOptions {
if (_raw.sdkRoot != null &&
!await fileSystem.entityForUri(sdkRoot).exists()) {
reportWithoutLocation(
- templateSdkRootNotFound.withArguments('$sdkRoot'), Severity.error);
+ templateSdkRootNotFound.withArguments(sdkRoot), Severity.error);
return false;
}
var summary = sdkSummary;
if (summary != null && !await fileSystem.entityForUri(summary).exists()) {
reportWithoutLocation(
- templateSdkSummaryNotFound.withArguments('$summary'), Severity.error);
+ templateSdkSummaryNotFound.withArguments(summary), Severity.error);
return false;
}
if (compileSdk && summary != null) {
reportWithoutLocation(
- templateInternalProblemUnsupported.withArguments(
- "The compileSdk and sdkSummary options are mutually exclusive"),
+ messageInternalProblemProvidedBothCompileSdkAndSdkSummary,
Severity.internalProblem);
return false;
}
@@ -407,7 +406,7 @@ class ProcessedOptions {
if (_raw.sdkRoot == null) {
// TODO(paulberry): implement the algorithm for finding the SDK
// automagically.
- return unimplemented('infer the default sdk location');
+ return unimplemented('infer the default sdk location', -1, null);
}
var root = _raw.sdkRoot;
if (!root.path.endsWith('/')) {
« no previous file with comments | « no previous file | pkg/front_end/lib/src/fasta/fasta_codes_generated.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698