Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2980273002: Random improvements in error reporting. (Closed)

Created:
3 years, 5 months ago by Siggi Cherem (dart-lang)
Modified:
3 years, 5 months ago
Reviewers:
ahe
CC:
reviews_dartlang.org, dart-uxr+reviews_google.com, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Random improvements in error reporting. R=ahe@google.com This mainly addresses comments and suggestions from https://codereview.chromium.org/2979623002/ Committed: https://github.com/dart-lang/sdk/commit/84828cff89053968a8906229047efed9f81b7309

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -38 lines) Patch
M pkg/front_end/lib/src/base/processed_options.dart View 1 3 chunks +5 lines, -6 lines 0 comments Download
M pkg/front_end/lib/src/fasta/fasta_codes_generated.dart View 1 3 chunks +35 lines, -24 lines 0 comments Download
M pkg/front_end/lib/src/fasta/problems.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/messages.yaml View 1 2 chunks +6 lines, -3 lines 0 comments Download
M pkg/front_end/test/kernel_generator_test.dart View 1 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/front_end/tool/_fasta/generate_messages.dart View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Siggi Cherem (dart-lang)
3 years, 5 months ago (2017-07-18 00:35:19 UTC) #1
ahe
lgtm
3 years, 5 months ago (2017-07-18 08:32:28 UTC) #2
Siggi Cherem (dart-lang)
3 years, 5 months ago (2017-07-19 17:45:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
84828cff89053968a8906229047efed9f81b7309 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698