Issue 2980243002: Add comments for constants which replaced large integer literals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2980243002: Add comments for constants which replaced large integer literals (Closed)

Created:
3 years, 5 months ago by alexmarkov

Modified:
3 years, 5 months ago

Reviewers:
zra, regis, floitsch, Lasse Reichstein Nielsen, siva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	runtime/lib/bigint.dart	View		1 chunk	+5 lines, -1 line	0 comments	Download
	M	runtime/lib/typed_data_patch.dart	View		1 chunk	+3 lines, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

alexmarkov

3 years, 5 months ago (2017-07-17 20:28:45 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
15e1136e3ef95952ca4110ceabfa14474b876e52 (presubmit successful).