Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: chrome/browser/ui/app_list/recommended_apps.h

Issue 298023009: Remove InstallTracker's extension load, unload observer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: DCHECK Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_APP_LIST_RECOMMENDED_APPS_H_ 5 #ifndef CHROME_BROWSER_UI_APP_LIST_RECOMMENDED_APPS_H_
6 #define CHROME_BROWSER_UI_APP_LIST_RECOMMENDED_APPS_H_ 6 #define CHROME_BROWSER_UI_APP_LIST_RECOMMENDED_APPS_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
11 #include "base/memory/ref_counted.h" 11 #include "base/memory/ref_counted.h"
12 #include "base/observer_list.h" 12 #include "base/observer_list.h"
13 #include "base/prefs/pref_change_registrar.h" 13 #include "base/prefs/pref_change_registrar.h"
14 #include "chrome/browser/extensions/install_observer.h" 14 #include "base/scoped_observer.h"
15 #include "extensions/browser/extension_registry_observer.h"
15 16
16 class Profile; 17 class Profile;
17 18
19 namespace extensions {
20 class ExtensionRegistry;
21 }
22
18 namespace app_list { 23 namespace app_list {
19 24
20 class RecommendedAppsObserver; 25 class RecommendedAppsObserver;
21 26
22 // A class that maintains a list of recommended apps by watching changes 27 // A class that maintains a list of recommended apps by watching changes
23 // to app state. 28 // to app state.
24 class RecommendedApps : public extensions::InstallObserver { 29 class RecommendedApps : public extensions::ExtensionRegistryObserver {
25 public: 30 public:
26 typedef std::vector<scoped_refptr<const extensions::Extension> > Apps; 31 typedef std::vector<scoped_refptr<const extensions::Extension> > Apps;
27 32
28 explicit RecommendedApps(Profile* profile); 33 explicit RecommendedApps(Profile* profile);
29 virtual ~RecommendedApps(); 34 virtual ~RecommendedApps();
30 35
31 void AddObserver(RecommendedAppsObserver* observer); 36 void AddObserver(RecommendedAppsObserver* observer);
32 void RemoveObserver(RecommendedAppsObserver* observer); 37 void RemoveObserver(RecommendedAppsObserver* observer);
33 38
34 const Apps& apps() const { return apps_; } 39 const Apps& apps() const { return apps_; }
35 40
36 private: 41 private:
37 void Update(); 42 void Update();
38 43
39 // extensions::InstallObserver overrides: 44 // extensions::ExtensionRegistryObserver overrides:
40 virtual void OnExtensionInstalled( 45 virtual void OnExtensionWillBeInstalled(
41 const extensions::Extension* extension) OVERRIDE; 46 content::BrowserContext* browser_context,
47 const extensions::Extension* extension,
48 bool is_update,
49 bool from_ephemeral,
50 const std::string& old_name) OVERRIDE;
42 virtual void OnExtensionLoaded( 51 virtual void OnExtensionLoaded(
52 content::BrowserContext* browser_context,
43 const extensions::Extension* extension) OVERRIDE; 53 const extensions::Extension* extension) OVERRIDE;
44 virtual void OnExtensionUnloaded( 54 virtual void OnExtensionUnloaded(
45 const extensions::Extension* extension) OVERRIDE; 55 content::BrowserContext* browser_context,
56 const extensions::Extension* extension,
57 extensions::UnloadedExtensionInfo::Reason reason) OVERRIDE;
46 virtual void OnExtensionUninstalled( 58 virtual void OnExtensionUninstalled(
59 content::BrowserContext* browser_context,
47 const extensions::Extension* extension) OVERRIDE; 60 const extensions::Extension* extension) OVERRIDE;
48 61
49 Profile* profile_; 62 Profile* profile_;
50 PrefChangeRegistrar pref_change_registrar_; 63 PrefChangeRegistrar pref_change_registrar_;
51 64
52 Apps apps_; 65 Apps apps_;
53 ObserverList<RecommendedAppsObserver, true> observers_; 66 ObserverList<RecommendedAppsObserver, true> observers_;
54 67
68 ScopedObserver<extensions::ExtensionRegistry,
69 extensions::ExtensionRegistryObserver>
70 extension_registry_observer_;
71
55 DISALLOW_COPY_AND_ASSIGN(RecommendedApps); 72 DISALLOW_COPY_AND_ASSIGN(RecommendedApps);
56 }; 73 };
57 74
58 } // namespace app_list 75 } // namespace app_list
59 76
60 #endif // CHROME_BROWSER_UI_APP_LIST_RECOMMENDED_APPS_H_ 77 #endif // CHROME_BROWSER_UI_APP_LIST_RECOMMENDED_APPS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698