Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Issue 298023006: Added early return in WebCore::TextResourceDecoder::checkForCSSCharset to fix buffer overflow (Closed)

Created:
6 years, 7 months ago by oystein (OOO til 10th of July)
Modified:
6 years, 7 months ago
Reviewers:
eseidel
CC:
blink-reviews, dglazkov+blink, blink-reviews-html_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@parser_crashfix
Visibility:
Public.

Description

Added early return in WebCore::TextResourceDecoder::checkForCSSCharset to fix buffer overflow Backported from Webkit: http://trac.webkit.org/changeset/169318 (patch by ddkilzer@apple.com) with a modified test to work for Blink. BUG=376800 R=eseidel Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174925

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
A LayoutTests/fast/encoding/css-charset-missing-semi-colon-and-newline.html View 1 chunk +8 lines, -0 lines 0 comments Download
A LayoutTests/fast/encoding/css-charset-missing-semi-colon-and-newline-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
A LayoutTests/fast/encoding/resources/css-charset-missing-semi-colon-and-newline.css View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/parser/TextResourceDecoder.cpp View 1 chunk +2 lines, -0 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
oystein (OOO til 10th of July)
6 years, 7 months ago (2014-05-27 23:32:15 UTC) #1
eseidel
lgtm https://codereview.chromium.org/298023006/diff/40001/Source/core/html/parser/TextResourceDecoder.cpp File Source/core/html/parser/TextResourceDecoder.cpp (right): https://codereview.chromium.org/298023006/diff/40001/Source/core/html/parser/TextResourceDecoder.cpp#newcode267 Source/core/html/parser/TextResourceDecoder.cpp:267: if (pos == dataEnd) Seems like we should ...
6 years, 7 months ago (2014-05-28 00:42:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oysteine@chromium.org/298023006/40001
6 years, 7 months ago (2014-05-28 00:43:17 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_rel on tryserver.blink ...
6 years, 7 months ago (2014-05-28 02:11:05 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-28 02:56:17 UTC) #5
Message was sent while issue was closed.
Change committed as 174925

Powered by Google App Engine
This is Rietveld 408576698