LayoutTests/crypto/aes-cbc-invalid-length.html - Issue 298023002: [webcrypto] Import WebKit's webcrypto tests.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/crypto/aes-cbc-invalid-length.html

Issue 298023002: [webcrypto] Import WebKit's webcrypto tests. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Modify the tests to work in blink Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <html>

	3 <head>

	4 <script src="../resources/js-test.js"></script>

	5 <script src="resources/common.js"></script>

	6 </head>

	7 <body>

	8 <p id="description"></p>

	9 <div id="console"></div>

	10

	11 <script>

	12 description("Test an unsupported AES key length.");

	13

	14 jsTestIsAsync = true;

	15

	16 var keyData = hexStringToUint8Array("8e73b0f7da0e6452c810f32b809079e562f8ead2522 c");

	17 var iv = hexStringToUint8Array("000102030405060708090a0b0c0d0e0f");

	18 var plaintext = hexStringToUint8Array("6bc1bee22e409f96e93d7e117393172aae2d8a571 e03ac9c9eb76fac45af8e5130c81c46a35ce411e5fbc1191a0a52eff69f2445df4f9b17ad2b417be 66c3710");

	19 var extractable = true;

	20

	21 debug("Importing a raw AES key from string literal...");

	22 crypto.subtle.importKey("raw", keyData, {name: "aes-cbc"}, extractable, ["encryp t", "decrypt"]).then(function(result) {

	23 debug("importKey() should have failed, since the key length was 176 bits");
	jww 2014/06/03 19:37:47 Why drop all the "shouldBe" sanity checks? Are you Why drop all the "shouldBe" sanity checks? Are you just assuming that unit testing elsewhere should catch all that stuff? Although looking at some of the later tests, you leave in the sanity checks, so I'm not sure which way you want to go. eroman 2014/06/03 19:52:04 Thanks for reading through all of those difference Show quoted text On 2014/06/03 19:37:47, jww wrote: > Why drop all the "shouldBe" sanity checks? Are you just assuming that unit > testing elsewhere should catch all that stuff? > > Although looking at some of the later tests, you leave in the sanity checks, so > I'm not sure which way you want to go. Thanks for reading through all of those differences! The removal of the shouldBe() is intentional. The reason is as follows: The original Webkit test does an importKey() for a 176 bit AES key. In WebKit, this operation succeeds, so it goes on to verify that the key was created with the expected properties, and goes on to try using it in an encrypt operation. By contrast in Blink, importKey() for a 176-bit AES key fails. So there are no properties to check on the key, just the error that was returned by importKey(). The Blink behavior matches the latest version of the spec, which says in section "18.11.4. Operations" regarding the raw import of AES-CBC keys: """If the length in bits of data is not 128, 192 or 256 then return an error named DataError.""" (The version of the spec which WebKit based this test off of was ambiguous on how to treat this, but the latest version is pretty clear).
	24 }).then(failAndFinishJSTest, function(result) {

	25 logError(result);

	26 }).then(finishJSTest, failAndFinishJSTest);

	27 </script>

	28

	29 </body>

	30 </html>

OLD	NEW

« no previous file with comments | « LayoutTests/crypto/aes-cbc-import-jwk-expected.txt ('k') | LayoutTests/crypto/aes-cbc-invalid-length-expected.txt » ('j') | no next file with comments »