Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issue 2980223002: Reapply CL "Option to truncate integers to 64 bits, part 2" (Closed)

Created:
3 years, 5 months ago by alexmarkov
Modified:
3 years, 5 months ago
Reviewers:
zra, regis, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Reapply CL "Option to truncate integers to 64 bits, part 2" This is the 2nd attempt to land the CL abed3c2a70856d54615890596a4a5db6cffe124f Original review: https://codereview.chromium.org/2982823002 No extra changes were made. Large literals in the Dart core library which caused failures during the previous attempt to land this CL have been fixed separately. Description of the CL: In --limit-ints-to-64-bits mode: * Integer constructors return Integer::null if integer is out of range. * Error is reported for integer literals which are out of range. * Dart API is revised to return errors if integers are out of range. Bigint::IsDisabled() method is introduced to be able to enable/disable Bigints independently of --limit-ints-to-64-bits mode in future. Deprecated constructor Integer::NewFromUint64 is replaced with Integer::New in certain cases. R=regis@google.com Issue: https://github.com/dart-lang/sdk/issues/30103 Committed: https://github.com/dart-lang/sdk/commit/bc937b3b6b4b1991547e00f852a6333699b64bc5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+193 lines, -92 lines) Patch
M runtime/lib/integers.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M runtime/lib/isolate.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/bigint_test.cc View 8 chunks +32 lines, -0 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 6 chunks +16 lines, -2 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 5 chunks +63 lines, -34 lines 0 comments Download
M runtime/vm/object.h View 2 chunks +4 lines, -0 lines 0 comments Download
M runtime/vm/object.cc View 14 chunks +37 lines, -29 lines 0 comments Download
M runtime/vm/object_test.cc View 5 chunks +27 lines, -17 lines 0 comments Download
M runtime/vm/regexp_assembler_ir.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/snapshot_test.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
alexmarkov
3 years, 5 months ago (2017-07-17 18:07:36 UTC) #2
regis
lgtm
3 years, 5 months ago (2017-07-17 18:32:08 UTC) #3
alexmarkov
3 years, 5 months ago (2017-07-17 19:20:27 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bc937b3b6b4b1991547e00f852a6333699b64bc5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698