Re-land beginning Dart 2.0 test migration.

Re-land beginning Dart 2.0 test migration.

This is similar to:

47985d6dbd85c541eb0374d95addf677af51ae5f
452d2d08402d5521ae2d09cd29d2c8147ac1cab2
7af2d86ed3cacec955171311e3660a54bf26a574

Except that it also fixes the status for dart2analyzer.

R=jcollins@google.com

Committed: https://github.com/dart-lang/sdk/commit/489c96ac2ef264c64ed961223723b0a4779192d8

[Bob Nystrom, 2017-07-17 17:49:15]

rnystrom@google.com changed reviewers:
+ jcollins@google.com

[Bob Nystrom, 2017-07-17 17:49:16]

This re-reverts the stuff aam@ had to revert on Friday, and also fixes
https://github.com/dart-lang/sdk/issues/30171.

[jcollins, 2017-07-17 18:04:03]

lgtm

https://codereview.chromium.org/2980213002/diff/1/tests/language_2/language_2...
File tests/language_2/language_2.status (right):

https://codereview.chromium.org/2980213002/diff/1/tests/language_2/language_2...
tests/language_2/language_2.status:7: [ $runtime == vm || $compiler == dart2js
|| $runtime == dart_precompiled || ($compiler == dart2analyzer && ! $strong) ]
would like to see us get to the point where !$strong isn't even considered in _2
directories

[Bob Nystrom, 2017-07-17 18:17:14]

On 2017/07/17 18:04:03, jcollins wrote:
> lgtm
> 
>
https://codereview.chromium.org/2980213002/diff/1/tests/language_2/language_2...
> File tests/language_2/language_2.status (right):
> 
>
https://codereview.chromium.org/2980213002/diff/1/tests/language_2/language_2...
> tests/language_2/language_2.status:7: [ $runtime == vm || $compiler == dart2js
> || $runtime == dart_precompiled || ($compiler == dart2analyzer && ! $strong) ]
> would like to see us get to the point where !$strong isn't even considered in
_2
> directories

The endpoint is that "$strong" will go away entirely, since it will no longer be
something you can opt out of. :)

I don't want to skip all tests in "_2" directories if "--strong" is omitted
because there are many migrated tests that do correctly pass even on
not-strong-yet implementations. For example, corelib/apply_test passes on the
VM, and we want to maintain that coverage during the migration.

– bob

[Bob Nystrom, 2017-07-17 19:40:23]

Description was changed from

==========
Re-land beginning Dart 2.0 test migration.

This is similar to:

47985d6dbd85c541eb0374d95addf677af51ae5f
452d2d08402d5521ae2d09cd29d2c8147ac1cab2
7af2d86ed3cacec955171311e3660a54bf26a574

Except that it also fixes the status for dart2analyzer.
==========

to

==========
Re-land beginning Dart 2.0 test migration.

This is similar to:

47985d6dbd85c541eb0374d95addf677af51ae5f
452d2d08402d5521ae2d09cd29d2c8147ac1cab2
7af2d86ed3cacec955171311e3660a54bf26a574

Except that it also fixes the status for dart2analyzer.

R=jcollins@google.com

Committed:
https://github.com/dart-lang/sdk/commit/489c96ac2ef264c64ed961223723b0a4779192d8
==========

[Bob Nystrom, 2017-07-17 19:40:24]

Committed patchset #1 (id:1) manually as
489c96ac2ef264c64ed961223723b0a4779192d8.