Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issue 298013004: Initialize JingleThreadWrapper in the Android client (Closed)

Created:
6 years, 7 months ago by Sergey Ulanov
Modified:
6 years, 7 months ago
Reviewers:
Lambros
CC:
chromium-reviews, chromoting-reviews_chromium.org
Visibility:
Public.

Description

Initialize JingleThreadWrapper in the Android client Previously Android client was crashing because JingleThreadWrapper was not initialized for the networking thread. It was broken by crrev.com/271351, which removed JingleThreadWrapper initialization from LijbingleTransportFactory. TBR=lambroslambrou@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272905

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M remoting/client/jni/chromoting_jni_instance.cc View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Sergey Ulanov
6 years, 7 months ago (2014-05-26 02:40:50 UTC) #1
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 7 months ago (2014-05-26 02:40:55 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/298013004/1
6 years, 7 months ago (2014-05-26 02:41:17 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-26 04:55:09 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-26 08:47:07 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/19793)
6 years, 7 months ago (2014-05-26 08:47:07 UTC) #6
Sergey Ulanov
The CQ bit was checked by sergeyu@chromium.org
6 years, 7 months ago (2014-05-26 23:18:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/298013004/1
6 years, 7 months ago (2014-05-26 23:19:04 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-27 01:03:31 UTC) #9
Message was sent while issue was closed.
Change committed as 272905

Powered by Google App Engine
This is Rietveld 408576698