Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 2980113002: fix #27320, better DDC temp generation (Closed)

Created:
3 years, 5 months ago by Jennifer Messerly
Modified:
3 years, 5 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix #

Patch Set 3 : fix #

Patch Set 4 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+85 lines, -56 lines) Patch
M pkg/dev_compiler/lib/src/compiler/code_generator.dart View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download
M pkg/dev_compiler/lib/src/compiler/js_metalet.dart View 1 2 3 5 chunks +70 lines, -48 lines 0 comments Download
M pkg/dev_compiler/lib/src/js_ast/nodes.dart View 1 2 3 1 chunk +6 lines, -1 line 0 comments Download
M pkg/dev_compiler/lib/src/js_ast/template.dart View 1 2 3 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Jennifer Messerly
3 years, 5 months ago (2017-07-14 21:03:42 UTC) #2
vsm
lgtm
3 years, 5 months ago (2017-07-17 15:02:21 UTC) #3
Jennifer Messerly
3 years, 5 months ago (2017-07-17 21:33:42 UTC) #5
Message was sent while issue was closed.
Committed patchset #4 (id:30001) manually as
87c0b757cb2a434f4655de96f04a56b5ceba237a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698