Further integration of front end type inference into analyzer.

Further integration of front end type inference into analyzer.

This CL propagates types for simple variable declarations into analyzer ASTs.

Note that for a variable declaration like `int x` we need to store two
pieces of information: the element pointed to by `int`, and the type
of `x`.  This CL handles the latter.  The former will wait until we
have enough of the element model built that we have an element to
point to.

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/df91c790783266d5fe55676c9f9563fc338bed1c

[Paul Berry, 2017-07-13 21:06:27]

paulberry@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2017-07-13 21:15:18]

LGTM

https://codereview.chromium.org/2980053002/diff/1/pkg/analyzer/lib/src/fasta/...
File pkg/analyzer/lib/src/fasta/resolution_applier.dart (right):

https://codereview.chromium.org/2980053002/diff/1/pkg/analyzer/lib/src/fasta/...
pkg/analyzer/lib/src/fasta/resolution_applier.dart:56: void
_applyTypeAnnotation(DartType type, TypeAnnotation typeAnnotation) {
I think it will do the opposite - apply "type" _to_ "typeAnnotation".
So, maybe it should be called _applyToTypeAnnotation(TypeAnnotation
typeAnnotation, DartType type).

[Paul Berry, 2017-07-13 21:17:05]

https://codereview.chromium.org/2980053002/diff/1/pkg/analyzer/lib/src/fasta/...
File pkg/analyzer/lib/src/fasta/resolution_applier.dart (right):

https://codereview.chromium.org/2980053002/diff/1/pkg/analyzer/lib/src/fasta/...
pkg/analyzer/lib/src/fasta/resolution_applier.dart:56: void
_applyTypeAnnotation(DartType type, TypeAnnotation typeAnnotation) {
On 2017/07/13 21:15:17, scheglov wrote:
> I think it will do the opposite - apply "type" _to_ "typeAnnotation".
> So, maybe it should be called _applyToTypeAnnotation(TypeAnnotation
> typeAnnotation, DartType type).

Done.

[Paul Berry, 2017-07-13 21:42:09]

Description was changed from

==========
Further integration of front end type inference into analyzer.

This CL propagates types for simple variable declarations into analyzer ASTs.

Note that for a variable declaration like `int x` we need to store two
pieces of information: the element pointed to by `int`, and the type
of `x`.  This CL handles the latter.  The former will wait until we
have enough of the element model built that we have an element to
point to.
==========

to

==========
Further integration of front end type inference into analyzer.

This CL propagates types for simple variable declarations into analyzer ASTs.

Note that for a variable declaration like `int x` we need to store two
pieces of information: the element pointed to by `int`, and the type
of `x`.  This CL handles the latter.  The former will wait until we
have enough of the element model built that we have an element to
point to.

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/df91c790783266d5fe55676c9f9563fc338bed1c
==========

[Paul Berry, 2017-07-13 21:42:11]

Committed patchset #1 (id:1) manually as
df91c790783266d5fe55676c9f9563fc338bed1c (presubmit successful).