Issue 2980043003: more fasta event cleanup and testing

Issue 2980043003: more fasta event cleanup and testing (Closed)

Created:
3 years, 5 months ago by danrubel

Modified:
3 years, 5 months ago

Reviewers:
ahe, scheglov

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/master

Visibility:
Public.

more fasta event cleanup and testing * make _end(optional: false) which uncovered unbalanced begin/end pairs * update and document top level member events * rename handleSwitchCase to endSwitchCase to better align with beginSwitchCase * update and document begin/endFor/endForIn events * cleanup test listener R=ahe@google.com, scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/f12be9d64dff14f0b4cebfc38eeab91ee21acf54

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+43 lines, -50 lines)			Patch
M	pkg/analyzer/lib/src/fasta/ast_builder.dart	View	1 chunk	+2 lines, -7 lines	0 comments	Download
M	pkg/analyzer/test/generated/parser_fasta_listener.dart	View	7 chunks	+27 lines, -25 lines	0 comments	Download
M	pkg/compiler/lib/src/parser/node_listener.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/front_end/lib/src/fasta/kernel/body_builder.dart	View	1 chunk	+2 lines, -7 lines	0 comments	Download
M	pkg/front_end/lib/src/fasta/parser/listener.dart	View	5 chunks	+10 lines, -9 lines	0 comments	Download
M	pkg/front_end/lib/src/fasta/parser/parser.dart	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (2 generated)

danrubel

3 years, 5 months ago (2017-07-14 16:28:18 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f12be9d64dff14f0b4cebfc38eeab91ee21acf54 (presubmit successful).