Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(290)

Issue 2980043002: Cleanup unused Dart API Dart_IdentityHash (Closed)

Created:
3 years, 5 months ago by alexmarkov
Modified:
3 years, 5 months ago
Reviewers:
zra, rmacnak, siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Cleanup unused Dart API Dart_IdentityHash There are a few problems with this function: * It returns uint64_t instead of int64_t, which is different from core Dart library function identityHashCode() * Dart_IdentityHash truncates negative Mint and Bigint values to 0, while negative Smi values are converted to uint64_t. The Dart_IdentityHash function is not used, so we decided to remove it instead of fixing these problems. R=zra@google.com Committed: https://github.com/dart-lang/sdk/commit/32e226be02ef1418a3c199b0336a4ea0e8f4d2fb

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -92 lines) Patch
M runtime/include/dart_api.h View 1 chunk +0 lines, -11 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 chunk +0 lines, -41 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 1 chunk +0 lines, -40 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
alexmarkov
3 years, 5 months ago (2017-07-13 20:34:04 UTC) #2
zra
lgtm
3 years, 5 months ago (2017-07-13 20:43:33 UTC) #3
alexmarkov
3 years, 5 months ago (2017-07-13 20:56:11 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
32e226be02ef1418a3c199b0336a4ea0e8f4d2fb (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698