Throw if there is no compiler context available

Throw if there is no compiler context available

BUG=
R=ahe@google.com

Committed: https://github.com/dart-lang/sdk/commit/8ecb50d0de5c1906469c920c69be75b794030a74

[Siggi Cherem (dart-lang), 2017-07-14 22:55:54]

Patchset #1 (id:1) has been deleted

[Siggi Cherem (dart-lang), 2017-07-14 22:56:00]

Patchset #1 (id:20001) has been deleted

[Siggi Cherem (dart-lang), 2017-07-14 22:56:29]

sigmund@google.com changed reviewers:
+ ahe@google.com

[ahe, 2017-07-17 08:42:07]

lgtm

https://codereview.chromium.org/2980033004/diff/40001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/compiler_context.dart (right):

https://codereview.chromium.org/2980033004/diff/40001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/compiler_context.dart:66: throw "$message\nTip:
$tip";
Add prefix:

Internal problem:

https://codereview.chromium.org/2980033004/diff/40001/pkg/front_end/messages....
File pkg/front_end/messages.yaml (right):

https://codereview.chromium.org/2980033004/diff/40001/pkg/front_end/messages....
pkg/front_end/messages.yaml:633: tip: "Wrap calls to the compiler in a zone with
a compiler context."
This sounds like an order (which is impolite). Also, it isn't obvious how to
create that zone. How about:

Are all calls to the compiler are wrapped in
'CompilerCommandLine.withGlobalOptions'?

This is the non-commanding version of "Make sure all calls...".

[Siggi Cherem (dart-lang), 2017-07-17 20:16:12]

Patchset #2 (id:60001) has been deleted

[Siggi Cherem (dart-lang), 2017-07-17 20:16:24]

Description was changed from

==========
Throw if there is no compiler context available

BUG=
==========

to

==========
Throw if there is no compiler context available

BUG=
R=ahe@google.com

Committed:
https://github.com/dart-lang/sdk/commit/8ecb50d0de5c1906469c920c69be75b794030a74
==========

[Siggi Cherem (dart-lang), 2017-07-17 20:16:26]

Committed patchset #3 (id:80001) manually as
8ecb50d0de5c1906469c920c69be75b794030a74 (presubmit successful).

[Siggi Cherem (dart-lang), 2017-07-17 20:18:38]

Thanks Peter!

PTAL after. I had to make a minor additional change: we were expecting a context
in two other situations I didn't include initially:
 - when constructing CommandLineOptions (we call `validate`)
 - when catching deprecated_InputError and reporting it back to the user

My change was to wrap these in a default context for now, but we will be able to
remove them soon (details in the TODO in command_line_options.dart)

https://codereview.chromium.org/2980033004/diff/40001/pkg/front_end/lib/src/f...
File pkg/front_end/lib/src/fasta/compiler_context.dart (right):

https://codereview.chromium.org/2980033004/diff/40001/pkg/front_end/lib/src/f...
pkg/front_end/lib/src/fasta/compiler_context.dart:66: throw "$message\nTip:
$tip";
On 2017/07/17 08:42:07, ahe wrote:
> Add prefix:
> 
> Internal problem: 

Done.

https://codereview.chromium.org/2980033004/diff/40001/pkg/front_end/messages....
File pkg/front_end/messages.yaml (right):

https://codereview.chromium.org/2980033004/diff/40001/pkg/front_end/messages....
pkg/front_end/messages.yaml:633: tip: "Wrap calls to the compiler in a zone with
a compiler context."
On 2017/07/17 08:42:07, ahe wrote:
> This sounds like an order (which is impolite). Also, it isn't obvious how to
> create that zone. How about:
> 
> Are all calls to the compiler are wrapped in
> 'CompilerCommandLine.withGlobalOptions'?
> 
> This is the non-commanding version of "Make sure all calls...".

Done.