[fsp] Fix error codes.

[fsp] Fix error codes.

This patch cleans up returned error codes. And now:
- base::File::FILE_ERROR_SECURITY is for policy errors, or not handled events.
- base::File::FILE_ERROR_ACCESS_DENIED for all writing operations.
- base::File::FILE_ERROR_INVALID_OPERATION for invalid arguments to operations
    or operations which are read-only but not yet implemented.

TEST=browser_tests, unit_tests: *FileSystemProvider*
BUG=373151
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273178

[mtomasz, 2014-05-27 04:56:59]

@hashimoto: PTAL. Thanks.

[hashimoto, 2014-05-27 11:12:51]

lgtm

[mtomasz, 2014-05-27 23:22:43]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2014-05-27 23:23:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mtomasz@chromium.org/298003006/20001

[commit-bot: I haz the power, 2014-05-28 00:32:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-28 00:32:41]

Failed to apply patch for
chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file
chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc
  Hunk #1 FAILED at 146.
  Hunk #2 succeeded at 192 (offset 4 lines).
  1 out of 2 hunks FAILED -- saving rejects to file
chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc.rej

Patch:      
chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc
Index: chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc
diff --git
a/chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc
b/chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc
index
52e1c68011722df35d4d33059d76a017f3229c4f..ddd846a447a2e47538d69b75b27f688297db0bac
100644
--- a/chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc
+++ b/chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc
@@ -146,9 +146,13 @@ void FakeProvidedFileSystem::OpenFile(const base::FilePath&
file_path,
                                       OpenFileMode mode,
                                       bool create,
                                       const OpenFileCallback& callback) {
-  if (file_path.AsUTF8Unsafe() != "/hello.txt" ||
-      mode == OPEN_FILE_MODE_WRITE || create) {
-    callback.Run(0 /* file_handle */, base::File::FILE_ERROR_SECURITY);
+  if (mode == OPEN_FILE_MODE_WRITE || create) {
+    callback.Run(0 /* file_handle */, base::File::FILE_ERROR_ACCESS_DENIED);
+    return;
+  }
+
+  if (file_path.AsUTF8Unsafe() != "/hello.txt") {
+    callback.Run(0 /* file_handle */, base::File::FILE_ERROR_NOT_FOUND);
     return;
   }
 
@@ -188,7 +192,7 @@ void FakeProvidedFileSystem::ReadFile(
         base::Bind(callback,
                    0 /* chunk_length */,
                    false /* has_next */,
-                   base::File::FILE_ERROR_SECURITY));
+                   base::File::FILE_ERROR_INVALID_OPERATION));
     return;
   }

[mtomasz, 2014-05-28 04:25:52]

The CQ bit was checked by mtomasz@chromium.org

[commit-bot: I haz the power, 2014-05-28 04:26:24]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mtomasz@chromium.org/298003006/40001

[commit-bot: I haz the power, 2014-05-28 06:26:55]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-05-28 08:36:46]

Change committed as 273178