Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 298003005: Revert of Support "Pin to taskbar" for hosted app windows. (Closed)

Created:
6 years, 7 months ago by sergeyv
Modified:
6 years, 7 months ago
Reviewers:
jackhou1, calamity, sky
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Revert of Support "Pin to taskbar" for hosted app windows. (https://codereview.chromium.org/258243002/) Reason for revert: Suspect to cause failure on Vista machines: http://build.chromium.org/p/chromium.win/builders/Vista%20Tests%20%283%29/builds/40163 Original issue's description: > Support "Pin to taskbar" for hosted app windows. > > This CL allows hosted app windows to be pinned to the taskbar by > right-clicking the taskbar icon and pressing the "Pin to taskbar" button. > > This CL pulls out the code that sets the relaunch details of v2 app > windows into web::UpdateRelaunchDetails. > > BUG=368101 > TEST=Run a hosted app as a window. Pin it from the taskbar icon right click > menu. Relaunch the app from the pinned icon. > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272851 NOTRY=true NOTREECHECKS=true TBR=calamity@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272866

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -177 lines) Patch
M chrome/browser/ui/views/apps/chrome_native_app_window_views_win.cc View 3 chunks +62 lines, -1 line 0 comments Download
M chrome/browser/ui/views/frame/browser_window_property_manager_browsertest_win.cc View 3 chunks +0 lines, -84 lines 0 comments Download
M chrome/browser/ui/views/frame/browser_window_property_manager_win.cc View 2 chunks +0 lines, -18 lines 0 comments Download
M chrome/browser/web_applications/web_app_win.h View 2 chunks +0 lines, -12 lines 0 comments Download
M chrome/browser/web_applications/web_app_win.cc View 3 chunks +0 lines, -62 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
sergeyv
Created Revert of Support "Pin to taskbar" for hosted app windows.
6 years, 7 months ago (2014-05-26 19:07:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/298003005/1
6 years, 7 months ago (2014-05-26 19:09:02 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-26 19:09:03 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 7 months ago (2014-05-26 19:09:03 UTC) #4
sergeyv
The CQ bit was checked by sergeyv@chromium.org
6 years, 7 months ago (2014-05-26 19:27:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyv@chromium.org/298003005/1
6 years, 7 months ago (2014-05-26 19:28:10 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-26 19:34:17 UTC) #7
Message was sent while issue was closed.
Change committed as 272866

Powered by Google App Engine
This is Rietveld 408576698