Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Unified Diff: tools/dom/templates/html/impl/impl_ShadowRoot.darttemplate

Issue 298003004: Deprecate ShadowRoot.applyAuthorStyles (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/dom/scripts/htmlrenamer.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/dom/templates/html/impl/impl_ShadowRoot.darttemplate
diff --git a/tools/dom/templates/html/impl/impl_ShadowRoot.darttemplate b/tools/dom/templates/html/impl/impl_ShadowRoot.darttemplate
index 7cdf52b7a6fa35562aa7907e4e81d0c14f409e16..2d518ba791fa63e2fc3d9518226f6ea717fdefba 100644
--- a/tools/dom/templates/html/impl/impl_ShadowRoot.darttemplate
+++ b/tools/dom/templates/html/impl/impl_ShadowRoot.darttemplate
@@ -16,27 +16,39 @@ $else
$endif
$if DART_USE_BLINK
- static bool _resetStyleInheritanceDeprecationReported = false;
- static void _resetStyleInheritanceDeprecationReport() {
- if (!_resetStyleInheritanceDeprecationReported) {
+ static bool _shadowRootDeprecationReported = false;
+ static void _shadowRootDeprecationReport() {
+ if (!_shadowRootDeprecationReported) {
window.console.warn('''
-ShadowRoot.resetStyleInheritance is now deprecated in dart:html.
-Please remove from your code.
+ShadowRoot.resetStyleInheritance and ShadowRoot.applyAuthorStyles now deprecated in dart:html.
+Please remove them from your code.
''');
- _resetStyleInheritanceDeprecationReported = true;
+ _shadowRootDeprecationReported = true;
}
}
@deprecated
bool get resetStyleInheritance {
- _resetStyleInheritanceDeprecationReport();
+ _shadowRootDeprecationReport();
// Default value from when it was specified.
return false;
}
@deprecated
void set resetStyleInheritance(bool value) {
- _resetStyleInheritanceDeprecationReport();
+ _shadowRootDeprecationReport();
+ }
+
+ @deprecated
+ bool get applyAuthorStyles {
+ _shadowRootDeprecationReport();
+ // Default value from when it was specified.
+ return false;
+ }
+
+ @deprecated
+ void set applyAuthorStyles(bool value) {
+ _shadowRootDeprecationReport();
}
$else
@deprecated
@@ -46,5 +58,13 @@ $else
void set resetStyleInheritance(bool value) {
this._resetStyleInheritance = value;
}
+
+ @deprecated
+ bool get applyAuthorStyles => this._applyAuthorStyles;
+
+ @deprecated
+ void set applyAuthorStyles(bool value) {
+ this._applyAuthorStyles = value;
+ }
$endif
}
« no previous file with comments | « tools/dom/scripts/htmlrenamer.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698