Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2980013002: Remove the "kompile" mode of running the front end. (Closed)

Created:
3 years, 5 months ago by Paul Berry
Modified:
3 years, 5 months ago
Reviewers:
ahe, scheglov
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove the "kompile" mode of running the front end. This mode was needed in the early days of the front end when we were contemplating the idea of building the analyzer AST representation of code first, and then converting it to kernel. Now that we build kernel directly, it is no longer needed. Further CLs will follow to remove code that is no longer used after this change. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/c9b42f6a41b10903f85ad7fc4bd1efd87a994357

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -651 lines) Patch
M pkg/front_end/lib/src/fasta/compiler_command_line.dart View 1 chunk +0 lines, -5 lines 0 comments Download
D pkg/front_end/test/fasta/kompile_test.dart View 1 chunk +0 lines, -20 lines 0 comments Download
D pkg/front_end/testcases/kompile.status View 1 chunk +0 lines, -541 lines 0 comments Download
M pkg/front_end/testing.json View 1 chunk +0 lines, -17 lines 0 comments Download
D pkg/front_end/tool/_fasta/analyzer_compile.dart View 1 chunk +0 lines, -67 lines 0 comments Download
M pkg/pkg.status View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Paul Berry
I only need a review from one of you.
3 years, 5 months ago (2017-07-13 17:28:45 UTC) #2
scheglov
LGTM
3 years, 5 months ago (2017-07-13 17:29:51 UTC) #3
Paul Berry
Committed patchset #1 (id:1) manually as c9b42f6a41b10903f85ad7fc4bd1efd87a994357 (presubmit successful).
3 years, 5 months ago (2017-07-13 17:53:00 UTC) #5
ahe
3 years, 5 months ago (2017-07-13 18:46:50 UTC) #6
Message was sent while issue was closed.
lgtm

Thank you!

Powered by Google App Engine
This is Rietveld 408576698