linux_aura: Bail early if we can't connect to the X11 server.

linux_aura: Add a "--display=" switch like GTK+ has.
    
Looking through crash output, we should do the right thing when chrome is run like this: "DISPLAY= chrome --display=:0.0"

BUG=376971
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=273725

[Elliot Glaysher, 2014-05-23 22:15:04]

Do you agree with my analysis of the bug? If so, is there a better place to do
this?

[piman, 2014-05-23 22:27:07]

Maybe in BrowserMainLoop::EarlyInitialization would be even better.
Right now content/ needs a valid Display through the Aura dependency, there's no
reason not to bail early in all content embedders.

[Elliot Glaysher, 2014-05-28 20:53:08]

Switching to sadrul since piman and danakj are out.

[sadrul, 2014-05-28 21:26:22]

lgtm

Maybe have a presubmit check that new code does not use XOpenDisplay(NULL)?

[Elliot Glaysher, 2014-05-29 00:21:55]

acolwell, asvitkine, kbr: owners stamps

[Elliot Glaysher, 2014-05-29 00:22:50]

-acolwell,+fischman: owners stamp since acolwell is ooo.

[Ami GONE FROM CHROMIUM, 2014-05-29 00:28:43]

LGTM with if-you-want-to suggestion

https://codereview.chromium.org/297983005/diff/90001/ui/gfx/x/x11_types.cc
File ui/gfx/x/x11_types.cc (right):

https://codereview.chromium.org/297983005/diff/90001/ui/gfx/x/x11_types.cc#ne...
ui/gfx/x/x11_types.cc:23: #if defined(OS_CHROMEOS)
CHECK cmd line value is not present, since you ignore it?

[Ken Russell (switch to Gerrit), 2014-05-29 00:32:48]

LGTM with fischman's comment addressed.

[Elliot Glaysher, 2014-05-29 00:35:22]

https://codereview.chromium.org/297983005/diff/90001/ui/gfx/x/x11_types.cc
File ui/gfx/x/x11_types.cc (right):

https://codereview.chromium.org/297983005/diff/90001/ui/gfx/x/x11_types.cc#ne...
ui/gfx/x/x11_types.cc:23: #if defined(OS_CHROMEOS)
On 2014/05/29 00:28:43, Ami Fischman wrote:
> CHECK cmd line value is not present, since you ignore it?

I don't think I can do this because switches::kX11Display isn't compiled in on
chromoes.

[Ami GONE FROM CHROMIUM, 2014-05-29 00:43:16]

On Wed, May 28, 2014 at 5:35 PM, <erg@chromium.org> wrote:

>
> https://codereview.chromium.org/297983005/diff/90001/ui/gfx/x/x11_types.cc
> File ui/gfx/x/x11_types.cc (right):
>
> https://codereview.chromium.org/297983005/diff/90001/ui/
> gfx/x/x11_types.cc#newcode23
> ui/gfx/x/x11_types.cc:23: #if defined(OS_CHROMEOS)
> On 2014/05/29 00:28:43, Ami Fischman wrote:
>
>> CHECK cmd line value is not present, since you ignore it?
>>
>
> I don't think I can do this because switches::kX11Display isn't compiled
> in on chromoes.
>

Even better.


>
> https://codereview.chromium.org/297983005/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Alexei Svitkine (slow), 2014-05-29 13:07:42]

LGTM

[Elliot Glaysher, 2014-05-29 17:59:13]

The CQ bit was checked by erg@chromium.org

[commit-bot: I haz the power, 2014-05-29 18:01:11]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/erg@chromium.org/297983005/110001

[commit-bot: I haz the power, 2014-05-29 23:14:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-29 23:14:27]

Failed to apply patch for ui/gfx/x/BUILD.gn:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  can't find file to patch at input line 6
  Perhaps you used the wrong -p or --strip option?
  The text leading up to this was:
  --------------------------
  |Index: ui/gfx/x/BUILD.gn
  |diff --git a/ui/gfx/x/BUILD.gn b/ui/gfx/x/BUILD.gn
  |index
23d6536e9163d4a8684974ef6a0ef27bd9ee8136..88c647357ccd779be8811c0b365f12aa5d02c6f5
100644
  |--- a/ui/gfx/x/BUILD.gn
  |+++ b/ui/gfx/x/BUILD.gn
  --------------------------
  No file to patch.  Skipping patch.
  1 out of 1 hunk ignored

Patch:       ui/gfx/x/BUILD.gn
Index: ui/gfx/x/BUILD.gn
diff --git a/ui/gfx/x/BUILD.gn b/ui/gfx/x/BUILD.gn
index
23d6536e9163d4a8684974ef6a0ef27bd9ee8136..88c647357ccd779be8811c0b365f12aa5d02c6f5
100644
--- a/ui/gfx/x/BUILD.gn
+++ b/ui/gfx/x/BUILD.gn
@@ -11,6 +11,8 @@ component("x") {
     "x11_connection.h",
     "x11_error_tracker.cc",
     "x11_error_tracker.h",
+    "x11_switches.cc",
+    "x11_switches.h",
     "x11_types.cc",
     "x11_types.h",
   ]

[Elliot Glaysher, 2014-05-30 00:45:15]

The CQ bit was checked by erg@chromium.org

[commit-bot: I haz the power, 2014-05-30 00:48:01]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/erg@chromium.org/297983005/130001

[commit-bot: I haz the power, 2014-05-30 05:31:18]

Change committed as 273725