Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2979783003: More equivalence testing (Closed)

Created:
3 years, 5 months ago by Johnni Winther
Modified:
3 years, 5 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

More equivalence testing - including a fix in checkLists! R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/66f19e67643fb704cb09ff4904fd33c9c655382a

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+150 lines, -23 lines) Patch
M pkg/compiler/lib/src/js_emitter/model.dart View 15 chunks +50 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/element_map_impl.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/kernel/env.dart View 2 chunks +8 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/equivalence/check_functions.dart View 10 chunks +89 lines, -11 lines 1 comment Download
M tests/compiler/dart2js/equivalence/check_helpers.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 5 months ago (2017-07-12 13:11:03 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/2979783003/diff/1/tests/compiler/dart2js/equivalence/check_functions.dart File tests/compiler/dart2js/equivalence/check_functions.dart (right): https://codereview.chromium.org/2979783003/diff/1/tests/compiler/dart2js/equivalence/check_functions.dart#newcode552 tests/compiler/dart2js/equivalence/check_functions.dart:552: env2.forEachSupertype(cls2, supertypes2.add); eek!
3 years, 5 months ago (2017-07-12 19:29:10 UTC) #3
Johnni Winther
3 years, 5 months ago (2017-07-13 11:24:05 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
66f19e67643fb704cb09ff4904fd33c9c655382a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698