Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1083)

Unified Diff: runtime/vm/class_finalizer.cc

Issue 2979763002: [VM generic function types] Properly set the scope function after parsing a (Closed)
Patch Set: address comments, move new test from language to language_2, sync Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/clustered_snapshot.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/class_finalizer.cc
diff --git a/runtime/vm/class_finalizer.cc b/runtime/vm/class_finalizer.cc
index da91d67627f2f3c60e931943a4b9d3e96e595e28..71e9132758a0601c69ee24c2fc3be450d6430c4e 100644
--- a/runtime/vm/class_finalizer.cc
+++ b/runtime/vm/class_finalizer.cc
@@ -1251,7 +1251,7 @@ RawAbstractType* ClassFinalizer::FinalizeType(const Class& cls,
Function& signature =
Function::Handle(zone, scope_class.signature_function());
if (!scope_class.is_type_finalized()) {
- FinalizeSignature(scope_class, signature);
+ FinalizeSignature(scope_class, signature, finalization);
}
// If the function type is a generic typedef, instantiate its signature
// from its type arguments.
@@ -1277,11 +1277,12 @@ RawAbstractType* ClassFinalizer::FinalizeType(const Class& cls,
// parameters were substituted in the signature with typedef type
// arguments). Note also that the function type parameters were not
// modified.
- FinalizeSignature(scope_class, signature); // Canonicalize signature.
+ FinalizeSignature(scope_class, signature, finalization);
}
fun_type.set_signature(signature);
} else {
- FinalizeSignature(cls, Function::Handle(zone, fun_type.signature()));
+ FinalizeSignature(cls, Function::Handle(zone, fun_type.signature()),
+ finalization);
}
}
« no previous file with comments | « no previous file | runtime/vm/clustered_snapshot.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698