Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(669)

Unified Diff: content/browser/loader/cross_site_resource_handler.cc

Issue 297973002: Navigation transitions: Block first response until after transitions have run. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/loader/cross_site_resource_handler.cc
diff --git a/content/browser/loader/cross_site_resource_handler.cc b/content/browser/loader/cross_site_resource_handler.cc
index 8fa7238c357086949984c5c2ad61ec585b9a83f7..29dc77ea6b08b14babbce8b77910e99e17e32ab8 100644
--- a/content/browser/loader/cross_site_resource_handler.cc
+++ b/content/browser/loader/cross_site_resource_handler.cc
@@ -16,6 +16,7 @@
#include "content/browser/frame_host/render_frame_host_impl.h"
#include "content/browser/loader/resource_dispatcher_host_impl.h"
#include "content/browser/loader/resource_request_info_impl.h"
+#include "content/browser/transition_request_manager.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/content_browser_client.h"
#include "content/public/browser/global_request_id.h"
@@ -84,6 +85,15 @@ void OnCrossSiteResponseHelper(const CrossSiteResponseParams& params) {
}
}
+void OnDeferredAfterResponseStartedHelper(
+ const GlobalRequestID& global_request_id,
+ int render_frame_id) {
+ RenderFrameHostImpl* rfh =
+ RenderFrameHostImpl::FromID(global_request_id.child_id, render_frame_id);
+ if (rfh)
+ rfh->OnDeferredAfterResponseStarted(global_request_id);
+}
+
bool CheckNavigationPolicyOnUI(GURL url, int process_id, int render_frame_id) {
RenderFrameHostImpl* rfh =
RenderFrameHostImpl::FromID(process_id, render_frame_id);
@@ -133,12 +143,32 @@ bool CrossSiteResourceHandler::OnRequestRedirected(
bool CrossSiteResourceHandler::OnResponseStarted(
ResourceResponse* response,
bool* defer) {
+ response_ = response;
+ has_started_response_ = true;
+
+ // Store this handler on the ExtraRequestInfo, so that RDH can call our
+ // ResumeResponse method when we are ready to resume.
+ ResourceRequestInfoImpl* info = GetRequestInfo();
+ info->set_cross_site_handler(this);
+
+ bool is_navigation_transition =
+ TransitionRequestManager::GetInstance()->HasPendingTransitionRequest(
+ info->GetChildID(), info->GetRenderFrameID());
+
+ if (is_navigation_transition)
+ return OnNavigationTransitionResponseStarted(response, defer);
+ else
+ return OnNormalResponseStarted(response, defer);
+}
+
+bool CrossSiteResourceHandler::OnNormalResponseStarted(
+ ResourceResponse* response,
+ bool* defer) {
// At this point, we know that the response is safe to send back to the
// renderer: it is not a download, and it has passed the SSL and safe
// browsing checks.
// We should not have already started the transition before now.
DCHECK(!in_cross_site_transition_);
- has_started_response_ = true;
ResourceRequestInfoImpl* info = GetRequestInfo();
@@ -197,6 +227,33 @@ bool CrossSiteResourceHandler::OnResponseStarted(
return true;
}
+bool CrossSiteResourceHandler::OnNavigationTransitionResponseStarted(
+ ResourceResponse* response,
+ bool* defer) {
+ ResourceRequestInfoImpl* info = GetRequestInfo();
+
+ GlobalRequestID global_id(info->GetChildID(), info->GetRequestID());
+ int render_frame_id = info->GetRenderFrameID();
+ BrowserThread::PostTask(
+ BrowserThread::UI,
+ FROM_HERE,
+ base::Bind(
+ &OnDeferredAfterResponseStartedHelper, global_id, render_frame_id));
+
+ *defer = true;
+ OnDidDefer();
+ return true;
+}
+
+void CrossSiteResourceHandler::ResumeResponseDeferredAtStart(int request_id) {
+ bool defer = false;
+ if (!OnNormalResponseStarted(response_, &defer)) {
+ controller()->Cancel();
+ } else if (!defer) {
+ ResumeIfDeferred();
+ }
+}
+
void CrossSiteResourceHandler::ResumeOrTransfer(bool is_transfer) {
if (is_transfer) {
StartCrossSiteTransition(response_, is_transfer);
« no previous file with comments | « content/browser/loader/cross_site_resource_handler.h ('k') | content/browser/loader/resource_dispatcher_host_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698