Navigation transitions: Block first response until after transitions have run.

content/browser/transition_request_message_filter.cc

Index: content/browser/transition_request_message_filter.cc
diff --git a/content/browser/transition_request_message_filter.cc b/content/browser/transition_request_message_filter.cc
new file mode 100644
index 0000000000000000000000000000000000000000..727f114b2c3c2635bb447597814a16a686c01da1
--- /dev/null
+++ b/content/browser/transition_request_message_filter.cc
@@ -0,0 +1,38 @@
+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/browser/transition_request_message_filter.h"
+
+#include "content/browser/transition_request_manager.h"
+#include "content/common/transition_request_messages.h"
+
+namespace content {
+
+TransitionRequestMessageFilter::TransitionRequestMessageFilter(int process_id)
+    : BrowserMessageFilter(TransitionRequestMsgStart),
+      process_id_(process_id) {
+}
+
+TransitionRequestMessageFilter::~TransitionRequestMessageFilter() {
+}
+
+bool TransitionRequestMessageFilter::OnMessageReceived(
+    const IPC::Message& message) {
+  switch (message.type()) {
+    case TransitionRequestHostMsg_SetHasPendingTransitionRequest::ID: {
+      TransitionRequestHostMsg_SetHasPendingTransitionRequest::Param param;
+      if (!TransitionRequestHostMsg_SetHasPendingTransitionRequest::Read(
+              &message, &param)) {

[jam, 2014/06/16 03:46:10]

hmm, since this is just dispatching one IPC, do this in RenderMessageFilter. no
point in adding another BMF just for this, unless you forsee a class of IPCs for
this feature (and if so, we can do split it out then). same for the IPC message
class and separate messages files. just put this in frame_messages.h

also when you move it, always use the standard IPC macros to crack and dispatch
IPCs, i.e. IPC_MESSAGE_HANDLER

[shatch, 2014/06/16 22:32:19]

Done.

+        return true;
+      }
+      TransitionRequestManager::GetInstance()->SetHasPendingTransitionRequest(
+          process_id_, message.routing_id(), param.a);
+    }
+    default:
+      break;
+  }
+  return true;
+}
+
+}  // namespace content