content/browser/web_contents/web_contents_impl.h - Issue 297973002: Navigation transitions: Block first response until after transitions have run.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.h

Issue 297973002: Navigation transitions: Block first response until after transitions have run. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes from review. Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/transition_request_manager.h ('K') | « content/browser/transition_request_manager.cc ('k') | content/browser/web_contents/web_contents_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/web_contents_impl.h

diff --git a/content/browser/web_contents/web_contents_impl.h b/content/browser/web_contents/web_contents_impl.h

index 8278efbefb179207529d871450e75c25602ab472..2300740772b4a77897ebb02a8a1c485e7432d8bc 100644

--- a/content/browser/web_contents/web_contents_impl.h

+++ b/content/browser/web_contents/web_contents_impl.h

@@ -313,6 +313,10 @@ class CONTENT_EXPORT WebContentsImpl

virtual void RemoveOverlayView() OVERRIDE;

#endif

+ // Notifies the main frame that it can continue navigation (if it was deferred

+ // immediately at first response).

+ virtual void ResumeResponseDeferredAtStart() OVERRIDE;

// Implementation of PageNavigator.

virtual WebContents* OpenURL(const OpenURLParams& params) OVERRIDE;

@@ -328,6 +332,7 @@ class CONTENT_EXPORT WebContentsImpl

virtual void DidStartLoading(RenderFrameHost* render_frame_host,

bool to_different_document) OVERRIDE;

virtual void SwappedOut(RenderFrameHost* render_frame_host) OVERRIDE;

+ virtual void DidDeferAfterResponseStarted() OVERRIDE;

virtual void WorkerCrashed(RenderFrameHost* render_frame_host) OVERRIDE;

virtual void ShowContextMenu(RenderFrameHost* render_frame_host,

const ContextMenuParams& params) OVERRIDE;